Cleanup CPDFXFA and CPDF document methods

Cleanup CPDFXFA and CPDF document methods

This CL renames and cleans up some methods that are similar between
CPDF_Document and CPDFXFA_Document.

Committed: https://pdfium.googlesource.com/pdfium/+/9f206f05eccf51089fe8a30bf52dc063ea5e2633

[dsinclair, 2016-09-20 13:17:06]

Patchset #2 (id:20001) has been deleted

[dsinclair, 2016-09-20 13:17:49]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 13:18:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 13:27:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 13:27:30]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-09-20 13:30:53]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-09-20 13:30:54]

PTAL.

https://codereview.chromium.org/2351673004/diff/1/core/fpdfapi/fpdf_parser/in...
File core/fpdfapi/fpdf_parser/include/cpdf_document.h (right):

https://codereview.chromium.org/2351673004/diff/1/core/fpdfapi/fpdf_parser/in...
core/fpdfapi/fpdf_parser/include/cpdf_document.h:52: int GetPageCount() const;
These two are grouped as they will become virtual in the future.

[npm, 2016-09-20 14:30:25]

lgtm

https://codereview.chromium.org/2351673004/diff/1/fpdfsdk/fpdfxfa/include/fpd...
File fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h (right):

https://codereview.chromium.org/2351673004/diff/1/fpdfsdk/fpdfxfa/include/fpd...
fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h:47: CPDFXFA_Page* GetXFAPage(int
page_index);
Why separate these?

[dsinclair, 2016-09-20 14:38:09]

https://codereview.chromium.org/2351673004/diff/1/fpdfsdk/fpdfxfa/include/fpd...
File fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h (right):

https://codereview.chromium.org/2351673004/diff/1/fpdfsdk/fpdfxfa/include/fpd...
fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h:47: CPDFXFA_Page* GetXFAPage(int
page_index);
On 2016/09/20 14:30:25, npm wrote:
> Why separate these?

Attempting to separate them from the methods that were going to be virtualized.

[dsinclair, 2016-09-20 18:04:43]

https://codereview.chromium.org/2351673004/diff/1/fpdfsdk/fpdfxfa/include/fpd...
File fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h (right):

https://codereview.chromium.org/2351673004/diff/1/fpdfsdk/fpdfxfa/include/fpd...
fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h:48: CPDFXFA_Page*
GetXFAPage(CXFA_FFPageView* pPage);
Tom, I renamed these because there is a CPDF_Dictionary* GetPage(int page_index)
in CPDF_Document and, I believe, we can't overload on the return type, yea?

[Tom Sepez, 2016-09-20 18:52:30]

lgtm

https://codereview.chromium.org/2351673004/diff/1/fpdfsdk/fpdfxfa/include/fpd...
File fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h (right):

https://codereview.chromium.org/2351673004/diff/1/fpdfsdk/fpdfxfa/include/fpd...
fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h:42: int GetDocType() { return m_iDocType;
}
nit: both of these are const?

https://codereview.chromium.org/2351673004/diff/1/fpdfsdk/fpdfxfa/include/fpd...
fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h:48: CPDFXFA_Page*
GetXFAPage(CXFA_FFPageView* pPage);
nit: these two too.

[dsinclair, 2016-09-20 19:02:54]

https://codereview.chromium.org/2351673004/diff/1/fpdfsdk/fpdfxfa/include/fpd...
File fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h (right):

https://codereview.chromium.org/2351673004/diff/1/fpdfsdk/fpdfxfa/include/fpd...
fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h:42: int GetDocType() { return m_iDocType;
}
On 2016/09/20 18:52:29, Tom Sepez wrote:
> nit: both of these are const?


GetSDKDocument can't be const as it may create the SDKDocument.

https://codereview.chromium.org/2351673004/diff/1/fpdfsdk/fpdfxfa/include/fpd...
fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h:48: CPDFXFA_Page*
GetXFAPage(CXFA_FFPageView* pPage);
On 2016/09/20 18:52:29, Tom Sepez wrote:
> nit: these two too.

One of these can be, the other can't. The int version may create the page before
returning it. The non-int version just returns pages.

[dsinclair, 2016-09-20 19:03:22]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-20 19:03:23]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
npm@chromium.org
Link to the patchset: https://codereview.chromium.org/2351673004/#ps40001
(title: "Review feedback")

[commit-bot: I haz the power, 2016-09-20 19:03:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 19:17:44]

Description was changed from

==========
Cleanup CPDFXFA and CPDF document methods

This CL renames and cleans up some methods that are similar between
CPDF_Document and CPDFXFA_Document.
==========

to

==========
Cleanup CPDFXFA and CPDF document methods

This CL renames and cleans up some methods that are similar between
CPDF_Document and CPDFXFA_Document.

Committed:
https://pdfium.googlesource.com/pdfium/+/9f206f05eccf51089fe8a30bf52dc063ea5e...
==========

[commit-bot: I haz the power, 2016-09-20 19:17:45]

Committed patchset #2 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/9f206f05eccf51089fe8a30bf52dc063ea5e...