Cleanup CPDFXFA and CPDF document methods

fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h"
 
 #include "core/fpdfapi/fpdf_parser/include/cpdf_document.h"
 #include "fpdfsdk/fpdfxfa/include/fpdfxfa_app.h"
@@ skipping 90 matching lines @@
     return FALSE;
   }
 
   m_pXFADocView->DoLayout(nullptr);
   m_pXFADocView->StopLayout();
   m_nLoadStatus = FXFA_LOADSTATUS_LOADED;
 
   return TRUE;
 }
 
-int CPDFXFA_Document::GetPageCount() {
+int CPDFXFA_Document::GetPageCount() const {
   if (!m_pPDFDoc && !m_pXFADoc)
     return 0;
 
   switch (m_iDocType) {
     case DOCTYPE_PDF:
     case DOCTYPE_STATIC_XFA:
       if (m_pPDFDoc)
         return m_pPDFDoc->GetPageCount();
     case DOCTYPE_DYNAMIC_XFA:
       if (m_pXFADoc)
         return m_pXFADocView->CountPageViews();
     default:
       return 0;
   }
 }
 
-CPDFXFA_Page* CPDFXFA_Document::GetPage(int page_index) {
+CPDFXFA_Page* CPDFXFA_Document::GetXFAPage(int page_index) {
   if (page_index < 0)
     return nullptr;
 
   CPDFXFA_Page* pPage = nullptr;
   int nCount = m_XFAPageList.GetSize();
   if (nCount > 0 && page_index < nCount) {
     pPage = m_XFAPageList.GetAt(page_index);
     if (pPage)
       pPage->Retain();
   } else {
     m_nPageCount = GetPageCount();
     m_XFAPageList.SetSize(m_nPageCount);
   }
   if (pPage)
     return pPage;
 
   pPage = new CPDFXFA_Page(this, page_index);
   if (!pPage->LoadPage()) {
     pPage->Release();
     return nullptr;
   }
   m_XFAPageList.SetAt(page_index, pPage);
   return pPage;
 }
 
-CPDFXFA_Page* CPDFXFA_Document::GetPage(CXFA_FFPageView* pPage) {
+CPDFXFA_Page* CPDFXFA_Document::GetXFAPage(CXFA_FFPageView* pPage) const {
   if (!pPage)
     return nullptr;
 
   if (!m_pXFADoc)
     return nullptr;
 
   if (m_iDocType != DOCTYPE_DYNAMIC_XFA)
     return nullptr;
 
   int nSize = m_XFAPageList.GetSize();
@@ skipping 30 matching lines @@
     CPDFSDK_Environment* pFormFillEnv) {
   if (!m_pSDKDoc && pFormFillEnv)
     m_pSDKDoc.reset(new CPDFSDK_Document(this, pFormFillEnv));
   return m_pSDKDoc.get();
 }
 
 void CPDFXFA_Document::ClearChangeMark() {
   if (m_pSDKDoc)
     m_pSDKDoc->ClearChangeMark();
 }