Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Issue 2351643005: [ic] Reorder parameters of StoreIC_Miss and KeyedStoreIC_Miss runtime functions. (Closed)

Created:
4 years, 3 months ago by Igor Sheludko
Modified:
4 years, 3 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Reorder parameters of StoreIC_Miss and KeyedStoreIC_Miss runtime functions. This will allow to simplify the miss part of store IC handlers when we decide to pass value/slot/vector on the stack. BUG=v8:5407 Committed: https://crrev.com/05eb56798e4d4bbd415a4bd369c7e9ffd6884d11 Cr-Commit-Position: refs/heads/master@{#39549}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -60 lines) Patch
M src/builtins/builtins-handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/code-stubs.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ic/ic.cc View 3 chunks +14 lines, -13 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/ic/ppc/ic-ppc.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/ic/s390/ic-s390.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M src/ic/x87/ic-x87.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Igor Sheludko
PTAL
4 years, 3 months ago (2016-09-20 08:02:34 UTC) #4
Toon Verwaest
lgtm
4 years, 3 months ago (2016-09-20 11:37:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351643005/1
4 years, 3 months ago (2016-09-20 12:22:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 12:25:39 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 12:26:29 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05eb56798e4d4bbd415a4bd369c7e9ffd6884d11
Cr-Commit-Position: refs/heads/master@{#39549}

Powered by Google App Engine
This is Rietveld 408576698