Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Side by Side Diff: src/ic/ia32/ic-ia32.cc

Issue 2351643005: [ic] Reorder parameters of StoreIC_Miss and KeyedStoreIC_Miss runtime functions. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/arm64/ic-arm64.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/ic-compiler.h" 9 #include "src/ic/ic-compiler.h"
10 #include "src/ic/stub-cache.h" 10 #include "src/ic/stub-cache.h"
(...skipping 693 matching lines...) Expand 10 before | Expand all | Expand 10 after
704 __ TailCallRuntime(Runtime::kKeyedGetProperty); 704 __ TailCallRuntime(Runtime::kKeyedGetProperty);
705 } 705 }
706 706
707 static void StoreIC_PushArgs(MacroAssembler* masm) { 707 static void StoreIC_PushArgs(MacroAssembler* masm) {
708 Register receiver = StoreDescriptor::ReceiverRegister(); 708 Register receiver = StoreDescriptor::ReceiverRegister();
709 Register name = StoreDescriptor::NameRegister(); 709 Register name = StoreDescriptor::NameRegister();
710 Register value = StoreDescriptor::ValueRegister(); 710 Register value = StoreDescriptor::ValueRegister();
711 Register slot = StoreWithVectorDescriptor::SlotRegister(); 711 Register slot = StoreWithVectorDescriptor::SlotRegister();
712 Register vector = StoreWithVectorDescriptor::VectorRegister(); 712 Register vector = StoreWithVectorDescriptor::VectorRegister();
713 713
714 __ xchg(receiver, Operand(esp, 0)); 714 __ xchg(value, Operand(esp, 0));
715 __ push(name);
716 __ push(value);
717 __ push(slot); 715 __ push(slot);
718 __ push(vector); 716 __ push(vector);
719 __ push(receiver); // Contains the return address. 717 __ push(receiver);
718 __ push(name);
719 __ push(value); // Contains the return address.
720 } 720 }
721 721
722 722
723 void StoreIC::GenerateMiss(MacroAssembler* masm) { 723 void StoreIC::GenerateMiss(MacroAssembler* masm) {
724 // Return address is on the stack. 724 // Return address is on the stack.
725 StoreIC_PushArgs(masm); 725 StoreIC_PushArgs(masm);
726 726
727 // Perform tail call to the entry. 727 // Perform tail call to the entry.
728 __ TailCallRuntime(Runtime::kStoreIC_Miss); 728 __ TailCallRuntime(Runtime::kStoreIC_Miss);
729 } 729 }
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
847 Condition cc = 847 Condition cc =
848 (check == ENABLE_INLINED_SMI_CHECK) 848 (check == ENABLE_INLINED_SMI_CHECK)
849 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero) 849 ? (*jmp_address == Assembler::kJncShortOpcode ? not_zero : zero)
850 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry); 850 : (*jmp_address == Assembler::kJnzShortOpcode ? not_carry : carry);
851 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 851 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
852 } 852 }
853 } // namespace internal 853 } // namespace internal
854 } // namespace v8 854 } // namespace v8
855 855
856 #endif // V8_TARGET_ARCH_IA32 856 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ic/arm64/ic-arm64.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698