Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2351623005: We don't compute propagated types of non-local variables. (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

We don't compute propagated types of non-local variables. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3355612e1312824a72eb8cf8f93102b275d8743f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -17 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 2 chunks +0 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 3 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 3 months ago (2016-09-20 03:39:27 UTC) #1
Paul Berry
lgtm
4 years, 3 months ago (2016-09-20 10:35:29 UTC) #2
scheglov
4 years, 3 months ago (2016-09-20 15:37:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3355612e1312824a72eb8cf8f93102b275d8743f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698