Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: pkg/analyzer/test/src/summary/resynthesize_common.dart

Issue 2351623005: We don't compute propagated types of non-local variables. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/test/src/summary/resynthesize_ast_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/summary/resynthesize_common.dart
diff --git a/pkg/analyzer/test/src/summary/resynthesize_common.dart b/pkg/analyzer/test/src/summary/resynthesize_common.dart
index 06396ec83276b95d4bd53a02b2dcdde1bea1d07d..bb75baf54e5a853899a8ea0e12b8505b766827da 100644
--- a/pkg/analyzer/test/src/summary/resynthesize_common.dart
+++ b/pkg/analyzer/test/src/summary/resynthesize_common.dart
@@ -47,8 +47,6 @@ abstract class AbstractResynthesizeTest extends AbstractSingleUnitTest {
*/
bool allowMissingFiles = false;
- bool get checkPropagatedTypes => true;
-
void addLibrary(String uri) {
otherLibrarySources.add(context.sourceFactory.forUri(uri));
}
@@ -712,7 +710,7 @@ abstract class AbstractResynthesizeTest extends AbstractSingleUnitTest {
compareElements(resynthesized, original, desc);
compareParameterElementLists(
resynthesized.parameters, original.parameters, desc);
- if (checkPropagatedTypes || !original.hasImplicitReturnType) {
+ if (!original.hasImplicitReturnType) {
compareTypes(
resynthesized.returnType, original.returnType, '$desc return type');
}
@@ -950,9 +948,6 @@ abstract class AbstractResynthesizeTest extends AbstractSingleUnitTest {
PropertyInducingElementImpl original,
String desc) {
compareVariableElements(resynthesized, original, desc);
- if (checkPropagatedTypes) {
- compareTypes(resynthesized.propagatedType, original.propagatedType, desc);
- }
if (original.getter == null) {
expect(resynthesized.getter, isNull);
} else {
« no previous file with comments | « pkg/analyzer/test/src/summary/resynthesize_ast_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698