Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(37)

Issue 2351603002: mojo: Use TYPE_DEFAULT message-loop for browser-tests. (Closed)

Created:
2 years, 2 months ago by sadrul
Modified:
2 years, 2 months ago
Reviewers:
jam, sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo: Use TYPE_DEFAULT message-loop for browser-tests. Use TYPE_DEFAULT message-loop for browser-tests, since that's what mojo_runner uses by default. We would normally use TYPE_DEFAULT message-loops for chrome --mash too, but keep using TYPE_UI for now, since mojo:ui needs that, and it is not known whether mojo:ui will be run at the type of the message-loop creation. Also, remove references to MessagePumpMojo since that has been removed. BUG=none TBR=jam@ for base/threading/ Committed: https://crrev.com/0b39ee9ed1b0cb8a87cf6b512230efb361a49e39 Cr-Commit-Position: refs/heads/master@{#419486}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M base/threading/thread_restrictions.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/app/mash/mash_runner.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/test/base/mash_browser_tests_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/public/cpp/service_runner.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 26 (17 generated)
sadrul
This fixes a crash in mash-browser-tests that starts showing up when sandboxing is turned on ...
2 years, 2 months ago (2016-09-19 05:47:19 UTC) #9
sky
LGTM
2 years, 2 months ago (2016-09-19 15:09:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351603002/40001
2 years, 2 months ago (2016-09-19 16:32:10 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/262045)
2 years, 2 months ago (2016-09-19 16:40:04 UTC) #16
sadrul
+jam@ for the base change. I am going to TBR since it's removing reference to ...
2 years, 2 months ago (2016-09-19 16:57:46 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351603002/40001
2 years, 2 months ago (2016-09-19 16:59:07 UTC) #21
jam
lgtm
2 years, 2 months ago (2016-09-19 17:02:10 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
2 years, 2 months ago (2016-09-19 17:07:01 UTC) #24
commit-bot: I haz the power
2 years, 2 months ago (2016-09-19 17:08:57 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0b39ee9ed1b0cb8a87cf6b512230efb361a49e39
Cr-Commit-Position: refs/heads/master@{#419486}

Powered by Google App Engine
This is Rietveld 408576698