Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: chrome/app/mash/mash_runner.cc

Issue 2351603002: mojo: Use TYPE_DEFAULT message-loop for browser-tests. (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/threading/thread_restrictions.h ('k') | chrome/test/base/mash_browser_tests_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/mash/mash_runner.cc
diff --git a/chrome/app/mash/mash_runner.cc b/chrome/app/mash/mash_runner.cc
index 78d14daa6f318860186021870f1044fe0473144a..e3c1c7334794ac989a4656479a79b2f1b63be7c5 100644
--- a/chrome/app/mash/mash_runner.cc
+++ b/chrome/app/mash/mash_runner.cc
@@ -126,7 +126,10 @@ void MashRunner::RunChild() {
void MashRunner::StartChildApp(
shell::mojom::ServiceRequest service_request) {
- // TODO(sky): use MessagePumpMojo.
+ // TODO(sad): Normally, this would be a TYPE_DEFAULT message loop. However,
+ // TYPE_UI is needed for mojo:ui. But it is not known whether the child app is
+ // going to be mojo:ui at this point. So always create a TYPE_UI message loop
+ // for now.
base::MessageLoop message_loop(base::MessageLoop::TYPE_UI);
service_.reset(new mash::MashPackagedService);
service_->set_context(base::MakeUnique<shell::ServiceContext>(
@@ -148,7 +151,6 @@ int MashMain() {
true, // Timestamp
true); // Tick count
- // TODO(sky): use MessagePumpMojo.
std::unique_ptr<base::MessageLoop> message_loop;
#if defined(OS_LINUX)
base::AtExitManager exit_manager;
« no previous file with comments | « base/threading/thread_restrictions.h ('k') | chrome/test/base/mash_browser_tests_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698