Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2351443002: Omnibox - Launch Change to Correctly Classify Typed Visits (Closed)

Created:
4 years, 3 months ago by Mark P
Modified:
4 years, 3 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Omnibox - Launch Change to Correctly Classify Typed Visits Delete the omnibox experiment and launch the new behavior unconditionally. BUG=369989, 468908 Committed: https://crrev.com/b732d27a550412eff4ada33d50430caf6f3ff200 Cr-Commit-Position: refs/heads/master@{#419578}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -22 lines) Patch
M components/omnibox/browser/omnibox_field_trial.h View 2 chunks +0 lines, -5 lines 0 comments Download
M components/omnibox/browser/omnibox_field_trial.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M components/omnibox/browser/scored_history_match.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/omnibox/browser/scored_history_match.cc View 3 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Mark P
Peter, please take a look at your leisure. It should be easy to review--it's so ...
4 years, 3 months ago (2016-09-16 22:53:12 UTC) #5
Peter Kasting
LGTM
4 years, 3 months ago (2016-09-19 18:40:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351443002/1
4 years, 3 months ago (2016-09-19 19:34:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 21:51:30 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:52:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b732d27a550412eff4ada33d50430caf6f3ff200
Cr-Commit-Position: refs/heads/master@{#419578}

Powered by Google App Engine
This is Rietveld 408576698