Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: components/omnibox/browser/scored_history_match.cc

Issue 2351443002: Omnibox - Launch Change to Correctly Classify Typed Visits (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/omnibox/browser/scored_history_match.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omnibox/browser/scored_history_match.cc
diff --git a/components/omnibox/browser/scored_history_match.cc b/components/omnibox/browser/scored_history_match.cc
index df76edb89d92bbd4915f7862035f25db6b97faed..024c6bdc05fc0cd9408ef7c1b7c8ae37816c6225 100644
--- a/components/omnibox/browser/scored_history_match.cc
+++ b/components/omnibox/browser/scored_history_match.cc
@@ -108,7 +108,6 @@ void InitDaysAgoToRecencyScoreArray() {
const size_t ScoredHistoryMatch::kMaxVisitsToScore = 10;
bool ScoredHistoryMatch::also_do_hup_like_scoring_ = false;
int ScoredHistoryMatch::bookmark_value_ = 1;
-bool ScoredHistoryMatch::fix_typed_visit_bug_ = false;
bool ScoredHistoryMatch::fix_few_visits_bug_ = false;
bool ScoredHistoryMatch::allow_tld_matches_ = false;
bool ScoredHistoryMatch::allow_scheme_matches_ = false;
@@ -429,7 +428,6 @@ void ScoredHistoryMatch::Init() {
initialized = true;
also_do_hup_like_scoring_ = OmniboxFieldTrial::HQPAlsoDoHUPLikeScoring();
bookmark_value_ = OmniboxFieldTrial::HQPBookmarkValue();
- fix_typed_visit_bug_ = OmniboxFieldTrial::HQPFixTypedVisitBug();
fix_few_visits_bug_ = OmniboxFieldTrial::HQPFixFewVisitsBug();
allow_tld_matches_ = OmniboxFieldTrial::HQPAllowMatchInTLDValue();
allow_scheme_matches_ = OmniboxFieldTrial::HQPAllowMatchInSchemeValue();
@@ -606,11 +604,8 @@ float ScoredHistoryMatch::GetFrequency(const base::Time& now,
const size_t max_visit_to_score =
std::min(visits.size(), ScoredHistoryMatch::kMaxVisitsToScore);
for (size_t i = 0; i < max_visit_to_score; ++i) {
- const bool is_page_transition_typed =
- fix_typed_visit_bug_ ? ui::PageTransitionCoreTypeIs(
- visits[i].second, ui::PAGE_TRANSITION_TYPED)
- : ui::PageTransitionTypeIncludingQualifiersIs(
- visits[i].second, ui::PAGE_TRANSITION_TYPED);
+ const bool is_page_transition_typed = ui::PageTransitionCoreTypeIs(
+ visits[i].second, ui::PAGE_TRANSITION_TYPED);
int value_of_transition = is_page_transition_typed ? 20 : 1;
if (bookmarked)
value_of_transition = std::max(value_of_transition, bookmark_value_);
« no previous file with comments | « components/omnibox/browser/scored_history_match.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698