Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 23514064: Revert 223644 "Revert 223585 "Revert 223398 "Remove old chromedr..." (Closed)

Created:
7 years, 3 months ago by kkania
Modified:
7 years, 3 months ago
Reviewers:
kkania
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 223644 "Revert 223585 "Revert 223398 "Remove old chromedr..." Broke chroot chromeos build (simplechrome works). > Revert 223585 "Revert 223398 "Remove old chromedriver from build..." > > Old ChromeDriver removed from chromeos: > https://chromium-review.googlesource.com/#/c/169601/ > > > Revert 223398 "Remove old chromedriver from build/archive. Sourc..." > > > > There's a long trail of error on the ChromeOS bots following this change (with complaints about ChromeDriver tests). > > Example: make: *** No rule to make target `chromedriver'. Stop. > > http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/16796/steps/BuildPackages/logs/stdio > > > > Seeing if this takes care of that error. > > > > > Remove old chromedriver from build/archive. Sources will be removed next. > > > BUG=none > > > > > > Review URL: https://chromiumcodereview.appspot.com/23542045 > > > > TBR=kkania@chromium.org > > > > Review URL: https://codereview.chromium.org/23650006 > > TBR=finnur@chromium.org > > Review URL: https://codereview.chromium.org/23686023 TBR=kkania@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223653

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -0 lines) Patch
trunk/src/build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
trunk/src/chrome/chrome_tests.gypi View 1 chunk +266 lines, -0 lines 0 comments Download
trunk/src/chrome/tools/build/linux/TESTS View 1 chunk +1 line, -0 lines 0 comments Download
trunk/src/chrome/tools/build/mac/TESTS View 1 chunk +1 line, -0 lines 0 comments Download
trunk/src/chrome/tools/build/win/TESTS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kkania
7 years, 3 months ago (2013-09-17 19:31:57 UTC) #1
kkania
7 years, 3 months ago (2013-09-17 19:32:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r223653.

Powered by Google App Engine
This is Rietveld 408576698