Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 23686023: Revert 223585 "Revert 223398 "Remove old chromedriver from build..." (Closed)

Created:
7 years, 3 months ago by kkania
Modified:
7 years, 3 months ago
Reviewers:
Finnur
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 223585 "Revert 223398 "Remove old chromedriver from build..." Old ChromeDriver removed from chromeos: https://chromium-review.googlesource.com/#/c/169601/ > Revert 223398 "Remove old chromedriver from build/archive. Sourc..." > > There's a long trail of error on the ChromeOS bots following this change (with complaints about ChromeDriver tests). > Example: make: *** No rule to make target `chromedriver'. Stop. > http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/16796/steps/BuildPackages/logs/stdio > > Seeing if this takes care of that error. > > > Remove old chromedriver from build/archive. Sources will be removed next. > > BUG=none > > > > Review URL: https://chromiumcodereview.appspot.com/23542045 > > TBR=kkania@chromium.org > > Review URL: https://codereview.chromium.org/23650006 TBR=finnur@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -270 lines) Patch
M trunk/src/build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/chrome_tests.gypi View 1 chunk +0 lines, -266 lines 0 comments Download
M trunk/src/chrome/tools/build/linux/TESTS View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/tools/build/mac/TESTS View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/tools/build/win/TESTS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
kkania
7 years, 3 months ago (2013-09-17 18:35:20 UTC) #1
kkania
Committed patchset #1 manually as r223644.
7 years, 3 months ago (2013-09-17 18:35:35 UTC) #2
Finnur
7 years, 3 months ago (2013-09-18 10:37:38 UTC) #3
LGTM


On Tue, Sep 17, 2013 at 6:35 PM, <kkania@chromium.org> wrote:

> Committed patchset #1 manually as r223644.
>
>
https://codereview.chromium.**org/23686023/<https://codereview.chromium.org/2...
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698