Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 23514023: Mac: Use CLANG_CXX_LANGUAGE_STANDARD instead of OTHER_CPLUSPLUSFLAGS for C++11. (Closed)

Created:
7 years, 3 months ago by Nico
Modified:
7 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, justincohen
Visibility:
Public.

Description

Mac: Use CLANG_CXX_LANGUAGE_STANDARD instead of OTHER_CPLUSPLUSFLAGS for C++11. No functionality change now that all bots are on Xcode 4, and it's a bit shorter and cleaner, and fixes a TODO. BUG=147515 R=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220729

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M build/common.gypi View 1 2 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
7 years, 3 months ago (2013-08-31 22:51:53 UTC) #1
Mark Mentovai
LGTM https://codereview.chromium.org/23514023/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/23514023/diff/1/build/common.gypi#newcode3873 build/common.gypi:3873: 'CLANG_CXX_LANGUAGE_STANDARD': 'gnu++11', Can you say # -std=gnu++11 here ...
7 years, 3 months ago (2013-08-31 22:54:17 UTC) #2
Nico
That was quick, thanks. https://codereview.chromium.org/23514023/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/23514023/diff/1/build/common.gypi#newcode3873 build/common.gypi:3873: 'CLANG_CXX_LANGUAGE_STANDARD': 'gnu++11', On 2013/08/31 22:54:17, ...
7 years, 3 months ago (2013-08-31 23:07:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/23514023/10001
7 years, 3 months ago (2013-08-31 23:14:05 UTC) #4
Nico
7 years, 3 months ago (2013-09-01 01:37:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r220729.

Powered by Google App Engine
This is Rietveld 408576698