Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: build/common.gypi

Issue 23514023: Mac: Use CLANG_CXX_LANGUAGE_STANDARD instead of OTHER_CPLUSPLUSFLAGS for C++11. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3847 matching lines...) Expand 10 before | Expand all | Expand 10 after
3858 'conditions': [ 3858 'conditions': [
3859 ['chromium_mac_pch', {'GCC_PRECOMPILE_PREFIX_HEADER': 'YES'}, 3859 ['chromium_mac_pch', {'GCC_PRECOMPILE_PREFIX_HEADER': 'YES'},
3860 {'GCC_PRECOMPILE_PREFIX_HEADER': 'NO'} 3860 {'GCC_PRECOMPILE_PREFIX_HEADER': 'NO'}
3861 ], 3861 ],
3862 # Note that the prebuilt Clang binaries should not be used for iOS 3862 # Note that the prebuilt Clang binaries should not be used for iOS
3863 # development except for ASan builds. 3863 # development except for ASan builds.
3864 ['clang==1', { 3864 ['clang==1', {
3865 'CC': '$(SOURCE_ROOT)/<(clang_dir)/clang', 3865 'CC': '$(SOURCE_ROOT)/<(clang_dir)/clang',
3866 'LDPLUSPLUS': '$(SOURCE_ROOT)/<(clang_dir)/clang++', 3866 'LDPLUSPLUS': '$(SOURCE_ROOT)/<(clang_dir)/clang++',
3867 3867
3868 # gnu++11 instead of c++11 is needed because some code uses
3869 # typeof() (a GNU extension).
3870 # TODO(thakis): Eventually switch this to c++11 instead of
3871 # gnu++11 (once typeof can be removed, which is blocked on c++11
3872 # being available everywhere).
3873 'CLANG_CXX_LANGUAGE_STANDARD': 'gnu++11', # -std=gnu++11
3868 # Don't use -Wc++0x-extensions, which Xcode 4 enables by default 3874 # Don't use -Wc++0x-extensions, which Xcode 4 enables by default
3869 # when building with clang. This warning is triggered when the 3875 # when building with clang. This warning is triggered when the
3870 # override keyword is used via the OVERRIDE macro from 3876 # override keyword is used via the OVERRIDE macro from
3871 # base/compiler_specific.h. 3877 # base/compiler_specific.h.
3872 'CLANG_WARN_CXX0X_EXTENSIONS': 'NO', 3878 'CLANG_WARN_CXX0X_EXTENSIONS': 'NO',
3873 # Warn if automatic synthesis is triggered with 3879 # Warn if automatic synthesis is triggered with
3874 # the -Wobjc-missing-property-synthesis flag. 3880 # the -Wobjc-missing-property-synthesis flag.
3875 'CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS': 'YES', 3881 'CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS': 'YES',
3876 'GCC_VERSION': 'com.apple.compilers.llvm.clang.1_0', 3882 'GCC_VERSION': 'com.apple.compilers.llvm.clang.1_0',
3877 'WARNING_CFLAGS': [ 3883 'WARNING_CFLAGS': [
(...skipping 17 matching lines...) Expand all
3895 '-Wno-covered-switch-default', 3901 '-Wno-covered-switch-default',
3896 3902
3897 # Warns when a const char[] is converted to bool. 3903 # Warns when a const char[] is converted to bool.
3898 '-Wstring-conversion', 3904 '-Wstring-conversion',
3899 3905
3900 # Clang considers the `register` keyword as deprecated, but e.g. 3906 # Clang considers the `register` keyword as deprecated, but e.g.
3901 # code generated by flex (used in angle) contains that keyword. 3907 # code generated by flex (used in angle) contains that keyword.
3902 # http://crbug.com/255186 3908 # http://crbug.com/255186
3903 '-Wno-deprecated-register', 3909 '-Wno-deprecated-register',
3904 ], 3910 ],
3905 'OTHER_CPLUSPLUSFLAGS': [
3906 # gnu++11 instead of c++11 is needed because some code uses
3907 # typeof() (a GNU extension).
3908 # TODO(thakis): Eventually switch this to c++11 instead of
3909 # gnu++11 (once typeof can be removed, which is blocked on c++11
3910 # being available everywhere).
3911 # TODO(thakis): Use CLANG_CXX_LANGUAGE_STANDARD instead once all
3912 # bots use xcode 4 -- http://crbug.com/147515).
3913 '$(inherited)', '-std=gnu++11',
3914 ],
3915 }], 3911 }],
3916 ['clang==1 and clang_use_chrome_plugins==1', { 3912 ['clang==1 and clang_use_chrome_plugins==1', {
3917 'OTHER_CFLAGS': [ 3913 'OTHER_CFLAGS': [
3918 '<@(clang_chrome_plugins_flags)', 3914 '<@(clang_chrome_plugins_flags)',
3919 ], 3915 ],
3920 }], 3916 }],
3921 ['clang==1 and clang_load!=""', { 3917 ['clang==1 and clang_load!=""', {
3922 'OTHER_CFLAGS': [ 3918 'OTHER_CFLAGS': [
3923 '-Xclang', '-load', '-Xclang', '<(clang_load)', 3919 '-Xclang', '-load', '-Xclang', '<(clang_load)',
3924 ], 3920 ],
(...skipping 793 matching lines...) Expand 10 before | Expand all | Expand 10 after
4718 # settings in target dicts. SYMROOT is a special case, because many other 4714 # settings in target dicts. SYMROOT is a special case, because many other
4719 # Xcode variables depend on it, including variables such as 4715 # Xcode variables depend on it, including variables such as
4720 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 4716 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
4721 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 4717 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
4722 # files to appear (when present) in the UI as actual files and not red 4718 # files to appear (when present) in the UI as actual files and not red
4723 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 4719 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
4724 # and therefore SYMROOT, needs to be set at the project level. 4720 # and therefore SYMROOT, needs to be set at the project level.
4725 'SYMROOT': '<(DEPTH)/xcodebuild', 4721 'SYMROOT': '<(DEPTH)/xcodebuild',
4726 }, 4722 },
4727 } 4723 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698