Issue 2351383002: swarming: Don't attempt to root android devices at every get_devices()

Issue 2351383002: swarming: Don't attempt to root android devices at every get_devices() (Closed)

Created:
4 years, 3 months ago by bpastene

Modified:
4 years, 3 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, infra-reviews+luci-py_chromium.org

Target Ref:
refs/heads/master

Project:
luci-py

Visibility:
Public.

swarming: Don't attempt to root android devices at every get_devices() BUG=643378 Committed: https://github.com/luci/luci-py/commit/d042a65966c7190f0c6fad87f1ceba4c62272cba

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	appengine/swarming/swarming_bot/api/platforms/android.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 7 (3 generated)

bpastene

Without this change, your desire to only root when needed is pretty much impossible.

4 years, 3 months ago (2016-09-20 21:59:24 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351383002/1

4 years, 3 months ago (2016-09-21 17:48:20 UTC) #5

commit-bot: I haz the power

4 years, 3 months ago (2016-09-21 17:51:37 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/d042a65966c7190f0c6fad87f1ceba4c62272cba