appengine/swarming/swarming_bot/api/platforms/android.py - Issue 2351383002: swarming: Don't attempt to root android devices at every get_devices()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/swarming/swarming_bot/api/platforms/android.py

Issue 2351383002: swarming: Don't attempt to root android devices at every get_devices() (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/swarming/swarming_bot/api/platforms/android.py

diff --git a/appengine/swarming/swarming_bot/api/platforms/android.py b/appengine/swarming/swarming_bot/api/platforms/android.py

index b6b397b9403d51b8da64fe0e56c8d10db41c8590..9132d7dcddda7f68809b69d3fd71752d0f9479a8 100644

--- a/appengine/swarming/swarming_bot/api/platforms/android.py

+++ b/appengine/swarming/swarming_bot/api/platforms/android.py

@@ -111,12 +111,12 @@ def get_devices(bot, endpoints=None):

if not gce.is_gce():

devices += high.GetLocalDevices(

'swarming', 10000, 10000, on_error=bot.post_error if bot else None,

- as_root=True)

+ as_root=False)

if endpoints:

devices += high.GetRemoteDevices(

'swarming', endpoints, 10000, 10000,

- on_error=bot.post_error if bot else None, as_root=True)

+ on_error=bot.post_error if bot else None, as_root=False)

return devices

« no previous file with comments | « no previous file | no next file » | no next file with comments »