Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1983)

Side by Side Diff: Source/bindings/dart/custom/DartDocumentCustom.cpp

Issue 23513085: Incorporating review feedback from https://codereview.chromium.org/24294002/ (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011, Google Inc. 1 // Copyright 2011, Google Inc.
2 // All rights reserved. 2 // All rights reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // * Redistributions of source code must retain the above copyright 8 // * Redistributions of source code must retain the above copyright
9 // notice, this list of conditions and the following disclaimer. 9 // notice, this list of conditions and the following disclaimer.
10 // * Redistributions in binary form must reproduce the above 10 // * Redistributions in binary form must reproduce the above
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope ; 81 CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope ;
82 82
83 const AtomicString& typeExtensionString = typeExtension; 83 const AtomicString& typeExtensionString = typeExtension;
84 if (typeExtensionString.isNull()) { 84 if (typeExtensionString.isNull()) {
85 result = receiver->createElement(localName, es); 85 result = receiver->createElement(localName, es);
86 } else { 86 } else {
87 result = receiver->createElement(localName, typeExtensionString, es); 87 result = receiver->createElement(localName, typeExtensionString, es);
88 } 88 }
89 } 89 }
90 90
91 Dart_SetReturnValue(args, DartElement::toDart(result)); 91 DartElement::returnToDart(args, result);
92 if (es.hadException()) { 92 if (es.hadException()) {
93 exception = DartDOMWrapper::exceptionCodeToDartException(es); 93 exception = DartDOMWrapper::exceptionCodeToDartException(es);
94 goto fail; 94 goto fail;
95 } 95 }
96 return; 96 return;
97 } 97 }
98 98
99 fail: 99 fail:
100 Dart_ThrowException(exception); 100 Dart_ThrowException(exception);
101 ASSERT_NOT_REACHED(); 101 ASSERT_NOT_REACHED();
(...skipping 23 matching lines...) Expand all
125 CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope ; 125 CustomElementCallbackDispatcher::CallbackDeliveryScope deliveryScope ;
126 126
127 const AtomicString& typeExtensionString = typeExtension; 127 const AtomicString& typeExtensionString = typeExtension;
128 if (typeExtensionString.isNull()) { 128 if (typeExtensionString.isNull()) {
129 result = receiver->createElementNS(namespaceURI, qualifiedName, es); 129 result = receiver->createElementNS(namespaceURI, qualifiedName, es);
130 } else { 130 } else {
131 result = receiver->createElementNS(namespaceURI, qualifiedName, typeExtensionString, es); 131 result = receiver->createElementNS(namespaceURI, qualifiedName, typeExtensionString, es);
132 } 132 }
133 } 133 }
134 134
135 Dart_SetReturnValue(args, DartElement::toDart(result)); 135 DartElement::returnToDart(args, result);
136 if (es.hadException()) { 136 if (es.hadException()) {
137 exception = DartDOMWrapper::exceptionCodeToDartException(es); 137 exception = DartDOMWrapper::exceptionCodeToDartException(es);
138 goto fail; 138 goto fail;
139 } 139 }
140 return; 140 return;
141 } 141 }
142 142
143 fail: 143 fail:
144 Dart_ThrowException(exception); 144 Dart_ThrowException(exception);
145 ASSERT_NOT_REACHED(); 145 ASSERT_NOT_REACHED();
146 } 146 }
147 147
148 } // namespace DartDocumentInternal 148 } // namespace DartDocumentInternal
149 149
150 } // namespace WebCore 150 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698