Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: Source/bindings/v8/ScriptString.h

Issue 23513066: Pass isolate to ScriptPromise and ScriptString constructors (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix nits Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/ScriptPromiseResolver.cpp ('k') | Source/bindings/v8/ScriptString.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ScriptString.h
diff --git a/Source/bindings/v8/ScriptString.h b/Source/bindings/v8/ScriptString.h
index f3a713404275151af3e921e7f562769278d084ad..ed493f8bf4866b4fa7c815a4df81a456703301f0 100644
--- a/Source/bindings/v8/ScriptString.h
+++ b/Source/bindings/v8/ScriptString.h
@@ -40,8 +40,7 @@ namespace WebCore {
class ScriptString : public ScriptValue {
public:
ScriptString() { }
- // FIXME: This constructor should take an isolate.
- explicit ScriptString(v8::Handle<v8::String> value) : ScriptValue(value, v8::Isolate::GetCurrent()) { }
+ ScriptString(v8::Handle<v8::String> value, v8::Isolate* isolate) : ScriptValue(value, isolate) { }
ScriptString concatenateWith(const String&);
String flattenToString() const;
« no previous file with comments | « Source/bindings/v8/ScriptPromiseResolver.cpp ('k') | Source/bindings/v8/ScriptString.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698