Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: Source/bindings/v8/ScriptPromiseResolver.cpp

Issue 23513066: Pass isolate to ScriptPromise and ScriptString constructors (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix nits Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/ScriptPromise.h ('k') | Source/bindings/v8/ScriptString.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ScriptPromiseResolver.cpp
diff --git a/Source/bindings/v8/ScriptPromiseResolver.cpp b/Source/bindings/v8/ScriptPromiseResolver.cpp
index 8743f738e5794a679bd9e45af5070897cc0ab1f3..7440a418b8b34ca62031a95c4f1be814c9a218c4 100644
--- a/Source/bindings/v8/ScriptPromiseResolver.cpp
+++ b/Source/bindings/v8/ScriptPromiseResolver.cpp
@@ -48,7 +48,7 @@ ScriptPromiseResolver::ScriptPromiseResolver(v8::Handle<v8::Object> creationCont
ASSERT(RuntimeEnabledFeatures::promiseEnabled());
v8::Local<v8::Object> promise, resolver;
V8PromiseCustom::createPromise(creationContext, &promise, &resolver, isolate);
- m_promise = ScriptPromise(promise);
+ m_promise = ScriptPromise(promise, isolate);
m_resolver.set(isolate, resolver);
}
« no previous file with comments | « Source/bindings/v8/ScriptPromise.h ('k') | Source/bindings/v8/ScriptString.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698