Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: Source/bindings/v8/ScriptPromise.h

Issue 23513066: Pass isolate to ScriptPromise and ScriptString constructors (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix nits Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/v8/ScriptPromiseResolver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ScriptPromise.h
diff --git a/Source/bindings/v8/ScriptPromise.h b/Source/bindings/v8/ScriptPromise.h
index 8ed4f0812ce48ad9022870894c8ff8aee3189c8e..c4f3e5dd07f88e8295eb7265bb111c55e873b965 100644
--- a/Source/bindings/v8/ScriptPromise.h
+++ b/Source/bindings/v8/ScriptPromise.h
@@ -50,15 +50,14 @@ public:
{
}
- explicit ScriptPromise(ScriptValue promise)
+ explicit ScriptPromise(const ScriptValue& promise)
: m_promise(promise)
{
ASSERT(!m_promise.hasNoValue());
}
- // FIXME: This constructor should take an isolate.
- explicit ScriptPromise(v8::Handle<v8::Value> promise)
- : m_promise(promise, v8::Isolate::GetCurrent())
+ ScriptPromise(v8::Handle<v8::Value> promise, v8::Isolate* isolate)
+ : m_promise(promise, isolate)
{
ASSERT(!m_promise.hasNoValue());
}
« no previous file with comments | « no previous file | Source/bindings/v8/ScriptPromiseResolver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698