Issue 23513065: also limit loops-per-canvas in picture_record_dictionaries, which has the same problem as unique_pa…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23513065: also limit loops-per-canvas in picture_record_dictionaries, which has the same problem as unique_pa… (Closed)

Created:
7 years, 3 months ago by mtklein

Modified:
7 years, 3 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

also limit loops-per-canvas in picture_record_dictionaries, which has the same problem as unique_paint BUG= R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=11327

Patch Set 2 : override #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -33 lines)			Patch
	M	bench/PictureRecordBench.cpp	View	1	5 chunks	+20 lines, -33 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + a nit https://codereview.chromium.org/23513065/diff/1/bench/PictureRecordBench.cpp File bench/PictureRecordBench.cpp (right): https://codereview.chromium.org/23513065/diff/1/bench/PictureRecordBench.cpp#newcode116 bench/PictureRecordBench.cpp:116: protected: override

7 years, 3 months ago (2013-09-17 18:35:13 UTC) #2

mtklein

https://codereview.chromium.org/23513065/diff/1/bench/PictureRecordBench.cpp File bench/PictureRecordBench.cpp (right): https://codereview.chromium.org/23513065/diff/1/bench/PictureRecordBench.cpp#newcode116 bench/PictureRecordBench.cpp:116: protected: On 2013/09/17 18:35:14, robertphillips wrote: > override Done.

7 years, 3 months ago (2013-09-17 18:58:34 UTC) #3

mtklein

7 years, 3 months ago (2013-09-17 18:58:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r11327 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23513065: also limit loops-per-canvas in picture_record_dictionaries, which has the same problem as unique_pa… (Closed)

Description

Patch Set 1 #

Patch Set 2 : override #

Messages