also limit loops-per-canvas in picture_record_dictionaries, which has the same problem as unique_pa…

bench/PictureRecordBench.cpp

 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #include "SkBenchmark.h"
 #include "SkCanvas.h"
 #include "SkColor.h"
 #include "SkPaint.h"
 #include "SkPicture.h"
 #include "SkPoint.h"
 #include "SkRandom.h"
 #include "SkRect.h"
 #include "SkString.h"
 
 class PictureRecordBench : public SkBenchmark {
 public:
     PictureRecordBench(const char name[])  {
         fName.printf("picture_record_%s", name);
         fIsRendering = false;
     }
 
     enum {
         PICTURE_WIDTH = 1000,
         PICTURE_HEIGHT = 4000,
     };
 protected:
-    virtual const char* onGetName() {
+    virtual const char* onGetName() SK_OVERRIDE {
         return fName.c_str();
     }
-
-    virtual void onDraw(SkCanvas*) {
-        SkPicture picture;
-
-        SkCanvas* pCanvas = picture.beginRecording(PICTURE_WIDTH, PICTURE_HEIGHT);
-        recordCanvas(pCanvas);
-
-        // we don't need to draw the picture as the endRecording step will
-        // do the work of transferring the recorded content into a playback
-        // object.
-        picture.endRecording();
-    }
-
-    virtual void recordCanvas(SkCanvas* canvas) = 0;
-
+private:
     SkString fName;
-private:
     typedef SkBenchmark INHERITED;
 };
 
+
+static const int kMaxLoopsPerCanvas = 10000;
+
 /*
  *  An SkPicture has internal dictionaries to store bitmaps, matrices, paints,
  *  and regions.  This bench populates those dictionaries to test the speed of
  *  reading and writing to those particular dictionary data structures.
  */
 class DictionaryRecordBench : public PictureRecordBench {
 public:
-    DictionaryRecordBench()
-        : INHERITED("dictionaries") { }
+    DictionaryRecordBench() : INHERITED("dictionaries") {}
 
 protected:
-    virtual void recordCanvas(SkCanvas* canvas) {
+    virtual void onDraw(SkCanvas*) SK_OVERRIDE {
+        SkAutoTDelete<SkPicture> picture;
+        SkCanvas* canvas = NULL;
 
         const SkPoint translateDelta = getTranslateDelta(this->getLoops());
 
         for (int i = 0; i < this->getLoops(); i++) {
+            if (0 == i % kMaxLoopsPerCanvas) {
+                picture.reset(SkNEW(SkPicture));
+                canvas = picture->beginRecording(PICTURE_WIDTH, PICTURE_HEIGHT);
+            }
 
             SkColor color = SK_ColorYELLOW + (i % 255);
             SkIRect rect = SkIRect::MakeWH(i % PICTURE_WIDTH, i % PICTURE_HEIGHT);
 
             canvas->save();
 
             // set the clip to the given region
             SkRegion region;
             region.setRect(rect);
             canvas->clipRegion(region);
@@ skipping 33 matching lines @@
 private:
     typedef PictureRecordBench INHERITED;
 };
 
 /*
  *  Populates the SkPaint dictionary with a large number of unique paint
  *  objects that differ only by color
  */
 class UniquePaintDictionaryRecordBench : public PictureRecordBench {
 public:
-    UniquePaintDictionaryRecordBench()
-        : INHERITED("unique_paint_dictionary") { }
+    UniquePaintDictionaryRecordBench() : INHERITED("unique_paint_dictionary") { }
 
 protected:
-    virtual void recordCanvas(SkCanvas* /*ignored*/) {
-        // We ignore the parent's canvas (which is just there for our
-        // convenience) because we've got to have more careful control over it.
-        // We start a new one every so often to prevent unbounded memory growth.
-
+    virtual void onDraw(SkCanvas*) SK_OVERRIDE {
         SkRandom rand;
         SkPaint paint;
         SkAutoTDelete<SkPicture> picture;
         SkCanvas* canvas = NULL;
-        const int kMaxPaintsPerCanvas = 10000;
         for (int i = 0; i < this->getLoops(); i++) {
-            if (0 == i % kMaxPaintsPerCanvas) {
+            if (0 == i % kMaxLoopsPerCanvas) {
                 picture.reset(SkNEW(SkPicture));
                 canvas = picture->beginRecording(PICTURE_WIDTH, PICTURE_HEIGHT);
             }
             paint.setColor(rand.nextU());
             canvas->drawPaint(paint);
         }
     }
 
 private:
     typedef PictureRecordBench INHERITED;
 };
 
 /*
  *  Populates the SkPaint dictionary with a number of unique paint
  *  objects that get reused repeatedly.
  *
  *  Re-creating the paint objects in the inner loop slows the benchmark down 10%.
  *  Using setColor(i % objCount) instead of a random color creates a very high rate
  *  of hash conflicts, slowing us down 12%.
  */
 class RecurringPaintDictionaryRecordBench : public PictureRecordBench {
 public:
-    RecurringPaintDictionaryRecordBench()
-        : INHERITED("recurring_paint_dictionary") {
+    RecurringPaintDictionaryRecordBench() : INHERITED("recurring_paint_dictionary") {
         SkRandom rand;
         for (int i = 0; i < ObjCount; i++) {
             fPaint[i].setColor(rand.nextU());
         }
     }
 
     enum {
         ObjCount = 100,  // number of unique paint objects
     };
 protected:
-    virtual void recordCanvas(SkCanvas* canvas) {
-
+    virtual void onDraw(SkCanvas*) SK_OVERRIDE {
+        SkPicture picture;
+        SkCanvas* canvas = picture.beginRecording(PICTURE_WIDTH, PICTURE_HEIGHT);
         for (int i = 0; i < this->getLoops(); i++) {
             canvas->drawPaint(fPaint[i % ObjCount]);
         }
     }
 
 private:
     SkPaint fPaint [ObjCount];
     typedef PictureRecordBench INHERITED;
 };
 
 ///////////////////////////////////////////////////////////////////////////////
 
 DEF_BENCH( return new DictionaryRecordBench(); )
 DEF_BENCH( return new UniquePaintDictionaryRecordBench(); )
 DEF_BENCH( return new RecurringPaintDictionaryRecordBench(); )