Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4256)

Unified Diff: chrome/browser/install_module_verifier_win.h

Issue 23513049: Implement install module verification metric. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/install_module_verifier_win.h
diff --git a/chrome/browser/install_module_verifier_win.h b/chrome/browser/install_module_verifier_win.h
new file mode 100644
index 0000000000000000000000000000000000000000..7731fd1c66e57eb81530d48cd591da5e7ae0a689
--- /dev/null
+++ b/chrome/browser/install_module_verifier_win.h
@@ -0,0 +1,31 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_INSTALL_MODULE_VERIFIER_WIN_H_
+#define CHROME_BROWSER_INSTALL_MODULE_VERIFIER_WIN_H_
+
+#include <set>
+#include "base/callback_forward.h"
sky 2013/09/24 20:16:16 nit: newline between 8/9
erikwright (departed) 2013/09/25 19:58:08 Done.
+#include "base/strings/string16.h"
+
+namespace base {
+class ListValue;
+} // namespace base
+
+// Starts a background process to verify installed modules. Results are reported
+// via UMA.
+void BeginModuleVerification();
+
+// Converts a list of modules descriptions extracted from EnumerateModulesModel
+// into a list of canonicalized loaded module names.
+void ExtractLoadedModuleNames(const base::ListValue& module_list,
+ std::set<base::string16>* loaded_module_names);
+
+// Verifies a list of installed modules and reports results via the supplied
+// callback. Each reported ID corresponds to a found, expected module listed in
+// expected_install_modules_win.h.
+void VerifyModules(const std::set<base::string16>& module_list,
+ const base::Callback<void(size_t)>& delegate);
sky 2013/09/24 20:16:16 Why the callback here? Is the plan that it'll be a
erikwright (departed) 2013/09/25 19:58:08 For testability. Internally the callback just does
sky 2013/10/04 18:20:46 Would a function pointer suffice then?
+
+#endif // CHROME_BROWSER_INSTALL_MODULE_VERIFIER_WIN_H_

Powered by Google App Engine
This is Rietveld 408576698