Implement install module verification metric.

chrome/browser/install_module_verifier_win.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_INSTALL_MODULE_VERIFIER_WIN_H_
+#define CHROME_BROWSER_INSTALL_MODULE_VERIFIER_WIN_H_
+
+#include <set>
+#include "base/callback_forward.h"

[sky, 2013/09/24 20:16:16]

nit: newline between 8/9

[erikwright (departed), 2013/09/25 19:58:08]

Done.

+#include "base/strings/string16.h"
+
+namespace base {
+class ListValue;
+}  // namespace base
+
+// Starts a background process to verify installed modules. Results are reported
+// via UMA.
+void BeginModuleVerification();
+
+// Converts a list of modules descriptions extracted from EnumerateModulesModel
+// into a list of canonicalized loaded module names.
+void ExtractLoadedModuleNames(const base::ListValue& module_list,
+                              std::set<base::string16>* loaded_module_names);
+
+// Verifies a list of installed modules and reports results via the supplied
+// callback. Each reported ID corresponds to a found, expected module listed in
+// expected_install_modules_win.h.
+void VerifyModules(const std::set<base::string16>& module_list,
+                   const base::Callback<void(size_t)>& delegate);

[sky, 2013/09/24 20:16:16]

Why the callback here? Is the plan that it'll be async soon?

[erikwright (departed), 2013/09/25 19:58:08]

For testability. Internally the callback just does a histogram, but the tests
can give a mock callback to verify the data that is being reported.

[sky, 2013/10/04 18:20:46]

Would a function pointer suffice then?

+
+#endif  // CHROME_BROWSER_INSTALL_MODULE_VERIFIER_WIN_H_