Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: src/parsing/preparser.h

Issue 2351233002: [parser] Refactor of Parse*Statement*, part 8 (Closed)
Patch Set: The real patch Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/parsing/parser-base.h ('K') | « src/parsing/parser-base.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/preparser.h
diff --git a/src/parsing/preparser.h b/src/parsing/preparser.h
index 7a6ee2a5c9debe2b853fbb0b6aa28c7081159625..adde41067f0e6ec438c447dcb3052bc4cc108c38 100644
--- a/src/parsing/preparser.h
+++ b/src/parsing/preparser.h
@@ -451,6 +451,8 @@ class PreParserStatement {
PreParserStatementList statements() { return PreParserStatementList(); }
void set_scope(Scope* scope) {}
void Initialize(PreParserExpression cond, PreParserStatement body) {}
+ void Initialize(PreParserStatement init, PreParserExpression cond,
+ PreParserStatement next, PreParserStatement body) {}
marja 2016/09/21 08:23:21 In addition, shouldn't you remove PreParser::Parse
nickie 2016/09/21 09:20:02 Yes, obviously. Done.
private:
enum Type {
@@ -666,6 +668,17 @@ class PreParserFactory {
return PreParserStatement::Default();
}
+ PreParserStatement NewForStatement(ZoneList<const AstRawString*>* labels,
+ int pos) {
+ return PreParserStatement::Default();
+ }
+
+ PreParserStatement NewForEachStatement(ForEachStatement::VisitMode visit_mode,
+ ZoneList<const AstRawString*>* labels,
+ int pos) {
+ return PreParserStatement::Default();
+ }
+
// Return the object itself as AstVisitor and implement the needed
// dummy method right in this class.
PreParserFactory* visitor() { return this; }
@@ -1121,6 +1134,40 @@ class PreParser : public ParserBase<PreParser> {
return PreParserExpression::Default();
}
+ V8_INLINE PreParserStatement
+ BuildInitializationBlock(DeclarationParsingResult* parsing_result,
+ ZoneList<const AstRawString*>* names, bool* ok) {
+ return PreParserStatement::Default();
+ }
+
+ V8_INLINE PreParserStatement
+ InitializeForEachStatement(PreParserStatement stmt, PreParserExpression each,
+ PreParserExpression subject,
+ PreParserStatement body, int each_keyword_pos) {
+ return stmt;
+ }
+
+ V8_INLINE PreParserStatement RewriteForVarInLegacy(ForInfo* for_info) {
+ return PreParserStatement::Null();
+ }
+ V8_INLINE std::pair<PreParserStatement, PreParserExpression>
+ DesugarBindingInForEachStatement(ForInfo* for_info, bool* ok) {
+ return std::make_pair(PreParserStatement::Default(),
+ PreParserExpression::Default());
+ }
+ V8_INLINE PreParserStatement CreateForEachStatementTDZ(
+ PreParserStatement init_block, ForInfo* for_info, bool* ok) {
+ return init_block;
+ }
+
+ V8_INLINE StatementT DesugarLexicalBindingsInForStatement(
+ PreParserStatement loop, PreParserStatement init,
+ PreParserExpression cond, PreParserStatement next,
+ PreParserStatement body, Scope* inner_scope, ForInfo* for_info,
+ bool* ok) {
+ return loop;
+ }
+
V8_INLINE PreParserExpression
NewThrowReferenceError(MessageTemplate::Template message, int pos) {
return PreParserExpression::Default();
« src/parsing/parser-base.h ('K') | « src/parsing/parser-base.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698