[parser] Refactor of Parse*Statement*, part 8

src/parsing/preparser.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_PARSING_PREPARSER_H
 #define V8_PARSING_PREPARSER_H
 
 #include "src/ast/scopes.h"
 #include "src/parsing/parser-base.h"
 
@@ skipping 433 matching lines @@
 
   bool IsEmptyStatement() { return code_ == kEmptyStatement; }
 
   // Dummy implementation for making statement->somefunc() work in both Parser
   // and PreParser.
   PreParserStatement* operator->() { return this; }
 
   PreParserStatementList statements() { return PreParserStatementList(); }
   void set_scope(Scope* scope) {}
   void Initialize(PreParserExpression cond, PreParserStatement body) {}
+  void Initialize(PreParserStatement init, PreParserExpression cond,
+                  PreParserStatement next, PreParserStatement body) {}
 

[marja, 2016/09/21 08:23:21]

In addition, shouldn't you remove PreParser::ParseForStatement?

[nickie, 2016/09/21 09:20:02]

Yes, obviously.  Done.

  private:
   enum Type {
     kNullStatement,
     kEmptyStatement,
     kUnknownStatement,
     kJumpStatement,
     kStringLiteralExpressionStatement,
     kUseStrictExpressionStatement,
     kUseAsmExpressionStatement,
   };
@@ skipping 194 matching lines @@
   PreParserStatement NewSwitchStatement(ZoneList<const AstRawString*>* labels,
                                         int pos) {
     return PreParserStatement::Default();
   }
 
   PreParserStatement NewCaseClause(PreParserExpression label,
                                    PreParserStatementList statements, int pos) {
     return PreParserStatement::Default();
   }
 
+  PreParserStatement NewForStatement(ZoneList<const AstRawString*>* labels,
+                                     int pos) {
+    return PreParserStatement::Default();
+  }
+
+  PreParserStatement NewForEachStatement(ForEachStatement::VisitMode visit_mode,
+                                         ZoneList<const AstRawString*>* labels,
+                                         int pos) {
+    return PreParserStatement::Default();
+  }
+
   // Return the object itself as AstVisitor and implement the needed
   // dummy method right in this class.
   PreParserFactory* visitor() { return this; }
   int* ast_properties() {
     static int dummy = 42;
     return &dummy;
   }
 };
 
 
@@ skipping 435 matching lines @@
   V8_INLINE PreParserExpression BuildUnaryExpression(
       PreParserExpression expression, Token::Value op, int pos) {
     return PreParserExpression::Default();
   }
 
   V8_INLINE PreParserExpression BuildIteratorResult(PreParserExpression value,
                                                     bool done) {
     return PreParserExpression::Default();
   }
 
+  V8_INLINE PreParserStatement
+  BuildInitializationBlock(DeclarationParsingResult* parsing_result,
+                           ZoneList<const AstRawString*>* names, bool* ok) {
+    return PreParserStatement::Default();
+  }
+
+  V8_INLINE PreParserStatement
+  InitializeForEachStatement(PreParserStatement stmt, PreParserExpression each,
+                             PreParserExpression subject,
+                             PreParserStatement body, int each_keyword_pos) {
+    return stmt;
+  }
+
+  V8_INLINE PreParserStatement RewriteForVarInLegacy(ForInfo* for_info) {
+    return PreParserStatement::Null();
+  }
+  V8_INLINE std::pair<PreParserStatement, PreParserExpression>
+  DesugarBindingInForEachStatement(ForInfo* for_info, bool* ok) {
+    return std::make_pair(PreParserStatement::Default(),
+                          PreParserExpression::Default());
+  }
+  V8_INLINE PreParserStatement CreateForEachStatementTDZ(
+      PreParserStatement init_block, ForInfo* for_info, bool* ok) {
+    return init_block;
+  }
+
+  V8_INLINE StatementT DesugarLexicalBindingsInForStatement(
+      PreParserStatement loop, PreParserStatement init,
+      PreParserExpression cond, PreParserStatement next,
+      PreParserStatement body, Scope* inner_scope, ForInfo* for_info,
+      bool* ok) {
+    return loop;
+  }
+
   V8_INLINE PreParserExpression
   NewThrowReferenceError(MessageTemplate::Template message, int pos) {
     return PreParserExpression::Default();
   }
 
   V8_INLINE PreParserExpression NewThrowSyntaxError(
       MessageTemplate::Template message, PreParserIdentifier arg, int pos) {
     return PreParserExpression::Default();
   }
 
@@ skipping 282 matching lines @@
     function_state_->NextMaterializedLiteralIndex();
     function_state_->NextMaterializedLiteralIndex();
   }
   return EmptyExpression();
 }
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_PARSING_PREPARSER_H