Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2351223002:
win/clang: Turn on -Wignored-pragmas again (Closed)
Descriptionwin/clang: Turn on -Wignored-pragmas again
clang-cl now implements `#pragma intrinsic` for all commonly used intrinsic, so this warning is no longer emitted.
BUG=644841
Committed: https://crrev.com/09fa985e68291a078d3bcaeb2d6fc4270cce4d7a
Cr-Commit-Position: refs/heads/master@{#427388}
Patch Set 1 #Patch Set 2 : try to trick analyze #Patch Set 3 : rebase #Messages
Total messages: 21 (16 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== win/clang: Try turning on -Wignored-pragmas again BUG=644841 ========== to ========== win/clang: Turn on -Wignored-pragmas again clang-cl now implements `#pragma intrin` for all commonly used intrinsic, so this warning is no longer emitted. BUG=644841 ==========
thakis@chromium.org changed reviewers: + hans@chromium.org
Yay! lgtm Ultra nit: put an a on 'intrinsic' in the cl description.
Description was changed from ========== win/clang: Turn on -Wignored-pragmas again clang-cl now implements `#pragma intrin` for all commonly used intrinsic, so this warning is no longer emitted. BUG=644841 ========== to ========== win/clang: Turn on -Wignored-pragmas again clang-cl now implements `#pragma intrinsic` for all commonly used intrinsic, so this warning is no longer emitted. BUG=644841 ==========
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== win/clang: Turn on -Wignored-pragmas again clang-cl now implements `#pragma intrinsic` for all commonly used intrinsic, so this warning is no longer emitted. BUG=644841 ========== to ========== win/clang: Turn on -Wignored-pragmas again clang-cl now implements `#pragma intrinsic` for all commonly used intrinsic, so this warning is no longer emitted. BUG=644841 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== win/clang: Turn on -Wignored-pragmas again clang-cl now implements `#pragma intrinsic` for all commonly used intrinsic, so this warning is no longer emitted. BUG=644841 ========== to ========== win/clang: Turn on -Wignored-pragmas again clang-cl now implements `#pragma intrinsic` for all commonly used intrinsic, so this warning is no longer emitted. BUG=644841 Committed: https://crrev.com/09fa985e68291a078d3bcaeb2d6fc4270cce4d7a Cr-Commit-Position: refs/heads/master@{#427388} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/09fa985e68291a078d3bcaeb2d6fc4270cce4d7a Cr-Commit-Position: refs/heads/master@{#427388} |
