Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2351223002: win/clang: Turn on -Wignored-pragmas again (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 927 matching lines...) Expand 10 before | Expand all | Expand 10 after
938 938
939 # Building with Clang on Windows is a work in progress and very 939 # Building with Clang on Windows is a work in progress and very
940 # experimental. See crbug.com/82385. 940 # experimental. See crbug.com/82385.
941 # Keep this in sync with the similar block in build/common.gypi 941 # Keep this in sync with the similar block in build/common.gypi
942 if (is_clang) { 942 if (is_clang) {
943 cflags += [ 943 cflags += [
944 # TODO(hans): Make this list shorter eventually, http://crbug.com/504657 944 # TODO(hans): Make this list shorter eventually, http://crbug.com/504657
945 "-Wno-microsoft-enum-value", # http://crbug.com/505296 945 "-Wno-microsoft-enum-value", # http://crbug.com/505296
946 "-Wno-unknown-pragmas", # http://crbug.com/505314 946 "-Wno-unknown-pragmas", # http://crbug.com/505314
947 "-Wno-microsoft-cast", # http://crbug.com/550065 947 "-Wno-microsoft-cast", # http://crbug.com/550065
948 "-Wno-ignored-pragmas", # http://crbug.com/644841
949 ] 948 ]
950 } 949 }
951 } else { 950 } else {
952 if (is_mac && !is_nacl) { 951 if (is_mac && !is_nacl) {
953 # When compiling Objective-C, warns if a method is used whose 952 # When compiling Objective-C, warns if a method is used whose
954 # availability is newer than the deployment target. This is not 953 # availability is newer than the deployment target. This is not
955 # required when compiling Chrome for iOS. 954 # required when compiling Chrome for iOS.
956 cflags += [ "-Wpartial-availability" ] 955 cflags += [ "-Wpartial-availability" ]
957 } 956 }
958 957
(...skipping 655 matching lines...) Expand 10 before | Expand all | Expand 10 after
1614 1613
1615 if (is_ios || is_mac) { 1614 if (is_ios || is_mac) {
1616 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1615 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1617 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1616 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1618 config("enable_arc") { 1617 config("enable_arc") {
1619 common_flags = [ "-fobjc-arc" ] 1618 common_flags = [ "-fobjc-arc" ]
1620 cflags_objc = common_flags 1619 cflags_objc = common_flags
1621 cflags_objcc = common_flags 1620 cflags_objcc = common_flags
1622 } 1621 }
1623 } 1622 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698