tests/compiler/dart2js/class_codegen2_test.dart - Issue 23512008: Call asyncEnd only on success.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/class_codegen2_test.dart

Issue 23512008: Call asyncEnd only on success. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/compiler/dart2js/class_codegen2_test.dart

diff --git a/tests/compiler/dart2js/class_codegen2_test.dart b/tests/compiler/dart2js/class_codegen2_test.dart

index 458e1d328c9abd089caeddcc78509d035a6d8165..0169e4e32c633d372036c5aeb40f4e6b38b3fbc0 100644

--- a/tests/compiler/dart2js/class_codegen2_test.dart

+++ b/tests/compiler/dart2js/class_codegen2_test.dart

@@ -90,10 +90,10 @@ main() {

// { a: true, }. Make sure this doesn't happen again.

RegExp danglingComma = new RegExp(r',[ \n]*}');

- asyncStart();

- Future.forEach([TEST_ONE, TEST_TWO, TEST_THREE, TEST_FOUR], (test) {

+ asyncTest(() => Future.forEach([TEST_ONE, TEST_TWO, TEST_THREE, TEST_FOUR],

+ (test) {

return compileAll(test).then((generated) {

Expect.isFalse(danglingComma.hasMatch(generated));

});

- }).whenComplete(() => asyncEnd());

+ }));

}