Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: tests/compiler/dart2js/class_codegen2_test.dart

Issue 23512008: Call asyncEnd only on success. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // Test that parameters keep their names in the output. 4 // Test that parameters keep their names in the output.
5 5
6 import 'dart:async'; 6 import 'dart:async';
7 import "package:expect/expect.dart"; 7 import "package:expect/expect.dart";
8 import "package:async_helper/async_helper.dart"; 8 import "package:async_helper/async_helper.dart";
9 import 'compiler_helper.dart'; 9 import 'compiler_helper.dart';
10 import 'parser_helper.dart'; 10 import 'parser_helper.dart';
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 main() { 83 main() {
84 foo(new A().foo); 84 foo(new A().foo);
85 } 85 }
86 """; 86 """;
87 87
88 main() { 88 main() {
89 // At some point Dart2js generated bad object literals with dangling commas: 89 // At some point Dart2js generated bad object literals with dangling commas:
90 // { a: true, }. Make sure this doesn't happen again. 90 // { a: true, }. Make sure this doesn't happen again.
91 RegExp danglingComma = new RegExp(r',[ \n]*}'); 91 RegExp danglingComma = new RegExp(r',[ \n]*}');
92 92
93 asyncStart(); 93 asyncTest(() => Future.forEach([TEST_ONE, TEST_TWO, TEST_THREE, TEST_FOUR],
94 Future.forEach([TEST_ONE, TEST_TWO, TEST_THREE, TEST_FOUR], (test) { 94 (test) {
95 return compileAll(test).then((generated) { 95 return compileAll(test).then((generated) {
96 Expect.isFalse(danglingComma.hasMatch(generated)); 96 Expect.isFalse(danglingComma.hasMatch(generated));
97 }); 97 });
98 }).whenComplete(() => asyncEnd()); 98 }));
99 } 99 }
OLDNEW
« no previous file with comments | « tests/compiler/dart2js/call_site_simple_type_inferer_test.dart ('k') | tests/compiler/dart2js/mirrors_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698