Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: tools/perf/measurements/rasterize_and_record.py

Issue 23512005: BrowserOptions.extra_browser_args is now a set. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/measurements/page_cycler.py ('k') | tools/perf/measurements/skpicture_printer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/rasterize_and_record.py
diff --git a/tools/perf/measurements/rasterize_and_record.py b/tools/perf/measurements/rasterize_and_record.py
index 5ff174d65fd254bbe349048db207239c7a8ab1de..1f56d3aa800283cd5a0b9f3b8caa6ef410cdb5d7 100644
--- a/tools/perf/measurements/rasterize_and_record.py
+++ b/tools/perf/measurements/rasterize_and_record.py
@@ -117,13 +117,14 @@ class RasterizeAndRecord(page_measurement.PageMeasurement):
# Run each raster task N times. This allows us to report the time for the
# best run, effectively excluding cache effects and time when the thread is
# de-scheduled.
- options.AppendExtraBrowserArg(
- '--slow-down-raster-scale-factor=' + str(options.raster_record_repeat))
- # Enable impl-side-painting. Current version of benchmark only works for
- # this mode.
- options.AppendExtraBrowserArg('--enable-impl-side-painting')
- options.AppendExtraBrowserArg('--force-compositing-mode')
- options.AppendExtraBrowserArg('--enable-threaded-compositing')
+ options.AppendExtraBrowserArgs([
+ '--slow-down-raster-scale-factor=%d' % options.raster_record_repeat,
+ # Enable impl-side-painting. Current version of benchmark only works for
+ # this mode.
+ '--enable-impl-side-painting',
+ '--force-compositing-mode',
+ '--enable-threaded-compositing'
+ ])
def MeasurePage(self, page, tab, results):
self._metrics = smoothness.SmoothnessMetrics(tab)
« no previous file with comments | « tools/perf/measurements/page_cycler.py ('k') | tools/perf/measurements/skpicture_printer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698