tools/telemetry/telemetry/unittest/tab_test_case.py - Issue 23512005: BrowserOptions.extra_browser_args is now a set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/unittest/tab_test_case.py

Issue 23512005: BrowserOptions.extra_browser_args is now a set. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: AppendExtraBrowserArgs Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/unittest/tab_test_case.py

diff --git a/tools/telemetry/telemetry/unittest/tab_test_case.py b/tools/telemetry/telemetry/unittest/tab_test_case.py

index 480da88604cb7e3085efaa6997e21dd09914c455..9ccd504f86a4f3079079e0fa38b632bb467fa13c 100644

--- a/tools/telemetry/telemetry/unittest/tab_test_case.py

+++ b/tools/telemetry/telemetry/unittest/tab_test_case.py

@@ -19,8 +19,7 @@ class TabTestCase(unittest.TestCase):

self.CustomizeBrowserOptions(options)

if self._extra_browser_args:

- for arg in self._extra_browser_args:

- options.extra_browser_args.append(arg)

+ options.AppendExtraBrowserArgs(self._extra_browser_args)

browser_to_create = browser_finder.FindBrowser(options)

if not browser_to_create: