tools/perf/measurements/smoothness.py - Issue 23512005: BrowserOptions.extra_browser_args is now a set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/smoothness.py

Issue 23512005: BrowserOptions.extra_browser_args is now a set. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: AppendExtraBrowserArgs Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/smoothness.py

diff --git a/tools/perf/measurements/smoothness.py b/tools/perf/measurements/smoothness.py

index 47a7802b7af51579fa5a3a4b95b17da47f804739..83b3ce40ae177f01322372018bf775bb97b220f6 100644

--- a/tools/perf/measurements/smoothness.py

+++ b/tools/perf/measurements/smoothness.py

@@ -29,7 +29,7 @@ class Smoothness(page_measurement.PageMeasurement):

def CustomizeBrowserOptions(self, options):

smoothness.SmoothnessMetrics.CustomizeBrowserOptions(options)

if self.force_enable_threaded_compositing:

- options.extra_browser_args.append('--enable-threaded-compositing')

+ options.AppendExtraBrowserArgs('--enable-threaded-compositing')

def CanRunForPage(self, page):

return hasattr(page, 'smoothness')