tools/perf/measurements/page_cycler.py - Issue 23512005: BrowserOptions.extra_browser_args is now a set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/page_cycler.py

Issue 23512005: BrowserOptions.extra_browser_args is now a set. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: AppendExtraBrowserArgs Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/measurements/page_cycler.py

diff --git a/tools/perf/measurements/page_cycler.py b/tools/perf/measurements/page_cycler.py

index 2e4e39c5a4a8aff429d33035f3cd37ed080d8458..dbf10fcd3b0f00c406c96bb140a77eb4ad94e7a6 100644

--- a/tools/perf/measurements/page_cycler.py

+++ b/tools/perf/measurements/page_cycler.py

@@ -82,7 +82,7 @@ class PageCycler(page_measurement.PageMeasurement):

def CustomizeBrowserOptions(self, options):

memory.MemoryMetric.CustomizeBrowserOptions(options)

io.IOMetric.CustomizeBrowserOptions(options)

- options.AppendExtraBrowserArg('--js-flags=--expose_gc')

+ options.AppendExtraBrowserArgs('--js-flags=--expose_gc')

if options.v8_object_stats:

self._record_v8_object_stats = True