Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 235113002: Oilpan: Remove guardRef and guardDeref from TreeScope. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comments. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLInputElement.cpp
diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp
index 7952c58f83be743b8803e9610ed433ab59f45558..03bb788a82123d35f12d842f94d1dfe6c684e543 100644
--- a/Source/core/html/HTMLInputElement.cpp
+++ b/Source/core/html/HTMLInputElement.cpp
@@ -157,6 +157,7 @@ void HTMLInputElement::willAddFirstAuthorShadowRoot()
HTMLInputElement::~HTMLInputElement()
{
+#if !ENABLE(OILPAN)
// Need to remove form association while this is still an HTMLInputElement
// so that virtual functions are called correctly.
setForm(0);
@@ -166,6 +167,7 @@ HTMLInputElement::~HTMLInputElement()
document().formController().radioButtonGroupScope().removeButton(this);
haraken 2014/04/25 05:21:42 Would you elaborate on why it's safe to remove thi
Mads Ager (chromium) 2014/04/25 10:58:25 Yes. With Oilpan, either the input element has bee
if (m_hasTouchEventHandler)
document().didRemoveTouchEventHandler(this);
+#endif
}
const AtomicString& HTMLInputElement::name() const

Powered by Google App Engine
This is Rietveld 408576698