Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: Source/core/dom/DocumentTest.cpp

Issue 235113002: Oilpan: Remove guardRef and guardDeref from TreeScope. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address review comments. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« Source/core/dom/Document.cpp ('K') | « Source/core/dom/DocumentMarkerController.cpp ('k') | Source/core/dom/Element.cpp » ('j') | Source/core/html/HTMLFormElement.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014, Google Inc. All rights reserved. 2 * Copyright (c) 2014, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 private: 49 private:
50 OwnPtr<DummyPageHolder> m_dummyPageHolder; 50 OwnPtr<DummyPageHolder> m_dummyPageHolder;
51 }; 51 };
52 52
53 void DocumentTest::SetUp() 53 void DocumentTest::SetUp()
54 { 54 {
55 m_dummyPageHolder = DummyPageHolder::create(IntSize(800, 600)); 55 m_dummyPageHolder = DummyPageHolder::create(IntSize(800, 600));
56 } 56 }
57 57
58 class MockDocumentVisibilityObserver : public DocumentVisibilityObserver { 58 class MockDocumentVisibilityObserver
59 : public NoBaseWillBeGarbageCollectedFinalized<MockDocumentVisibilityObserve r>
60 , public DocumentVisibilityObserver {
61 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MockDocumentVisibilityObserver);
59 public: 62 public:
60 MockDocumentVisibilityObserver(Document& document) : DocumentVisibilityObser ver(document) { } 63 static PassOwnPtrWillBeRawPtr<MockDocumentVisibilityObserver> create(Documen t& document)
64 {
65 return adoptPtrWillBeNoop(new MockDocumentVisibilityObserver(document));
66 }
67
68 virtual void trace(Visitor*) { }
61 69
62 MOCK_METHOD1(didChangeVisibilityState, void(PageVisibilityState)); 70 MOCK_METHOD1(didChangeVisibilityState, void(PageVisibilityState));
71
72 private:
73 MockDocumentVisibilityObserver(Document& document) : DocumentVisibilityObser ver(document) { }
63 }; 74 };
64 75
65 TEST_F(DocumentTest, VisibilityOberver) 76 TEST_F(DocumentTest, VisibilityOberver)
66 { 77 {
67 page().setVisibilityState(PageVisibilityStateVisible, true); // initial stat e 78 page().setVisibilityState(PageVisibilityStateVisible, true); // initial stat e
68 MockDocumentVisibilityObserver observer1(document()); 79 OwnPtrWillBeRawPtr<MockDocumentVisibilityObserver> observer1 = MockDocumentV isibilityObserver::create(document());
69 80
70 { 81 {
71 MockDocumentVisibilityObserver observer2(document()); 82 OwnPtrWillBeRawPtr<MockDocumentVisibilityObserver> observer2 = MockDocum entVisibilityObserver::create(document());
72 EXPECT_CALL(observer1, didChangeVisibilityState(PageVisibilityStateHidde n)).Times(0); 83 EXPECT_CALL(*observer1, didChangeVisibilityState(PageVisibilityStateHidd en)).Times(0);
73 EXPECT_CALL(observer1, didChangeVisibilityState(PageVisibilityStateVisib le)).Times(0); 84 EXPECT_CALL(*observer1, didChangeVisibilityState(PageVisibilityStateVisi ble)).Times(0);
74 EXPECT_CALL(observer2, didChangeVisibilityState(PageVisibilityStateHidde n)).Times(0); 85 EXPECT_CALL(*observer2, didChangeVisibilityState(PageVisibilityStateHidd en)).Times(0);
75 EXPECT_CALL(observer2, didChangeVisibilityState(PageVisibilityStateVisib le)).Times(0); 86 EXPECT_CALL(*observer2, didChangeVisibilityState(PageVisibilityStateVisi ble)).Times(0);
76 ::testing::Mock::VerifyAndClearExpectations(&observer1); 87 ::testing::Mock::VerifyAndClearExpectations(observer1.get());
77 ::testing::Mock::VerifyAndClearExpectations(&observer2); 88 ::testing::Mock::VerifyAndClearExpectations(observer2.get());
78 89
79 EXPECT_CALL(observer1, didChangeVisibilityState(PageVisibilityStateHidde n)).Times(1); 90 EXPECT_CALL(*observer1, didChangeVisibilityState(PageVisibilityStateHidd en)).Times(1);
80 EXPECT_CALL(observer1, didChangeVisibilityState(PageVisibilityStateVisib le)).Times(0); 91 EXPECT_CALL(*observer1, didChangeVisibilityState(PageVisibilityStateVisi ble)).Times(0);
81 EXPECT_CALL(observer2, didChangeVisibilityState(PageVisibilityStateHidde n)).Times(1); 92 EXPECT_CALL(*observer2, didChangeVisibilityState(PageVisibilityStateHidd en)).Times(1);
82 EXPECT_CALL(observer2, didChangeVisibilityState(PageVisibilityStateVisib le)).Times(0); 93 EXPECT_CALL(*observer2, didChangeVisibilityState(PageVisibilityStateVisi ble)).Times(0);
83 page().setVisibilityState(PageVisibilityStateHidden, false); 94 page().setVisibilityState(PageVisibilityStateHidden, false);
84 ::testing::Mock::VerifyAndClearExpectations(&observer1); 95 ::testing::Mock::VerifyAndClearExpectations(observer1.get());
85 ::testing::Mock::VerifyAndClearExpectations(&observer2); 96 ::testing::Mock::VerifyAndClearExpectations(observer2.get());
86 97
87 EXPECT_CALL(observer1, didChangeVisibilityState(PageVisibilityStateHidde n)).Times(0); 98 EXPECT_CALL(*observer1, didChangeVisibilityState(PageVisibilityStateHidd en)).Times(0);
88 EXPECT_CALL(observer1, didChangeVisibilityState(PageVisibilityStateVisib le)).Times(0); 99 EXPECT_CALL(*observer1, didChangeVisibilityState(PageVisibilityStateVisi ble)).Times(0);
89 EXPECT_CALL(observer2, didChangeVisibilityState(PageVisibilityStateHidde n)).Times(0); 100 EXPECT_CALL(*observer2, didChangeVisibilityState(PageVisibilityStateHidd en)).Times(0);
90 EXPECT_CALL(observer2, didChangeVisibilityState(PageVisibilityStateVisib le)).Times(0); 101 EXPECT_CALL(*observer2, didChangeVisibilityState(PageVisibilityStateVisi ble)).Times(0);
91 page().setVisibilityState(PageVisibilityStateHidden, false); 102 page().setVisibilityState(PageVisibilityStateHidden, false);
92 ::testing::Mock::VerifyAndClearExpectations(&observer1); 103 ::testing::Mock::VerifyAndClearExpectations(observer1.get());
93 ::testing::Mock::VerifyAndClearExpectations(&observer2); 104 ::testing::Mock::VerifyAndClearExpectations(observer2.get());
94 105
95 EXPECT_CALL(observer1, didChangeVisibilityState(PageVisibilityStateHidde n)).Times(0); 106 EXPECT_CALL(*observer1, didChangeVisibilityState(PageVisibilityStateHidd en)).Times(0);
96 EXPECT_CALL(observer1, didChangeVisibilityState(PageVisibilityStateVisib le)).Times(1); 107 EXPECT_CALL(*observer1, didChangeVisibilityState(PageVisibilityStateVisi ble)).Times(1);
97 EXPECT_CALL(observer2, didChangeVisibilityState(PageVisibilityStateHidde n)).Times(0); 108 EXPECT_CALL(*observer2, didChangeVisibilityState(PageVisibilityStateHidd en)).Times(0);
98 EXPECT_CALL(observer2, didChangeVisibilityState(PageVisibilityStateVisib le)).Times(0); 109 EXPECT_CALL(*observer2, didChangeVisibilityState(PageVisibilityStateVisi ble)).Times(0);
99 OwnPtr<DummyPageHolder> alternatePage = DummyPageHolder::create(IntSize( 800, 600)); 110 OwnPtr<DummyPageHolder> alternatePage = DummyPageHolder::create(IntSize( 800, 600));
100 Document& alternateDocument = alternatePage->document(); 111 Document& alternateDocument = alternatePage->document();
101 observer2.setObservedDocument(alternateDocument); 112 observer2->setObservedDocument(alternateDocument);
102 page().setVisibilityState(PageVisibilityStateVisible, false); 113 page().setVisibilityState(PageVisibilityStateVisible, false);
103 ::testing::Mock::VerifyAndClearExpectations(&observer1); 114 ::testing::Mock::VerifyAndClearExpectations(observer1.get());
104 ::testing::Mock::VerifyAndClearExpectations(&observer2); 115 ::testing::Mock::VerifyAndClearExpectations(observer2.get());
105 116
106 EXPECT_CALL(observer1, didChangeVisibilityState(PageVisibilityStateHidde n)).Times(1); 117 EXPECT_CALL(*observer1, didChangeVisibilityState(PageVisibilityStateHidd en)).Times(1);
107 EXPECT_CALL(observer1, didChangeVisibilityState(PageVisibilityStateVisib le)).Times(0); 118 EXPECT_CALL(*observer1, didChangeVisibilityState(PageVisibilityStateVisi ble)).Times(0);
108 EXPECT_CALL(observer2, didChangeVisibilityState(PageVisibilityStateHidde n)).Times(1); 119 EXPECT_CALL(*observer2, didChangeVisibilityState(PageVisibilityStateHidd en)).Times(1);
109 EXPECT_CALL(observer2, didChangeVisibilityState(PageVisibilityStateVisib le)).Times(0); 120 EXPECT_CALL(*observer2, didChangeVisibilityState(PageVisibilityStateVisi ble)).Times(0);
110 observer2.setObservedDocument(document()); 121 observer2->setObservedDocument(document());
111 page().setVisibilityState(PageVisibilityStateHidden, false); 122 page().setVisibilityState(PageVisibilityStateHidden, false);
112 ::testing::Mock::VerifyAndClearExpectations(&observer1); 123 ::testing::Mock::VerifyAndClearExpectations(observer1.get());
113 ::testing::Mock::VerifyAndClearExpectations(&observer2); 124 ::testing::Mock::VerifyAndClearExpectations(observer2.get());
114 } 125 }
115 126
116 // observer2 destroyed 127 // observer2 destroyed
117 EXPECT_CALL(observer1, didChangeVisibilityState(PageVisibilityStateHidden)). Times(0); 128 EXPECT_CALL(*observer1, didChangeVisibilityState(PageVisibilityStateHidden)) .Times(0);
118 EXPECT_CALL(observer1, didChangeVisibilityState(PageVisibilityStateVisible)) .Times(1); 129 EXPECT_CALL(*observer1, didChangeVisibilityState(PageVisibilityStateVisible) ).Times(1);
119 page().setVisibilityState(PageVisibilityStateVisible, false); 130 page().setVisibilityState(PageVisibilityStateVisible, false);
120 } 131 }
121 132
122 } // unnamed namespace 133 } // unnamed namespace
OLDNEW
« Source/core/dom/Document.cpp ('K') | « Source/core/dom/DocumentMarkerController.cpp ('k') | Source/core/dom/Element.cpp » ('j') | Source/core/html/HTMLFormElement.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698