Prune CreateVisiblePositionDeprecated from Editor::canDeleteRange

Prune CreateVisiblePositionDeprecated from Editor::canDeleteRange

Editor::canDeleteRange tries to create VisiblePositions when called with
a collapsed range, but the function is only called with a non-collapsed
range. This patch simply removes the dead code for handling collapsed
range and get rid of the creation of VisiblePositions.

BUG=647219
Committed: https://crrev.com/0a91d0e81b21800a4c603fb46db2b7648c11ffda
Cr-Commit-Position: refs/heads/master@{#419712}

[Xiaocheng, 2016-09-20 03:16:29]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 03:16:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-20 04:21:04]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-09-20 04:21:05]

PTAL.

[commit-bot: I haz the power, 2016-09-20 04:44:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 04:44:27]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-09-20 07:58:40]

lgtm

https://codereview.chromium.org/2351103002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/Editor.cpp (right):

https://codereview.chromium.org/2351103002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/Editor.cpp:285: bool
Editor::canDeleteRange(const EphemeralRange& range) const
Since |canDeleteRange()| is called only from |shouldDeleteRange()|, it seems we
can integrate into |canDeleteRange()|.
If it goes to be simpler, it is worth to try. I'm OK to do so in this CL. Of
course, it is better to after this CL. Because, moving code is smaller. ;-)

https://codereview.chromium.org/2351103002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/Editor.cpp:287:
DCHECK(!range.isCollapsed());
nit: Could you add |<< *range| for |DCHECK()|?

[Xiaocheng, 2016-09-20 08:11:38]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 08:11:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-20 08:12:35]

Thanks for the review!

https://codereview.chromium.org/2351103002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/Editor.cpp (right):

https://codereview.chromium.org/2351103002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/Editor.cpp:285: bool
Editor::canDeleteRange(const EphemeralRange& range) const
On 2016/09/20 at 07:58:39, Yosi_UTC9 wrote:
> Since |canDeleteRange()| is called only from |shouldDeleteRange()|, it seems
we can integrate into |canDeleteRange()|.
> If it goes to be simpler, it is worth to try. I'm OK to do so in this CL. Of
course, it is better to after this CL. Because, moving code is smaller. ;-)

TODO added.

https://codereview.chromium.org/2351103002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/Editor.cpp:287:
DCHECK(!range.isCollapsed());
On 2016/09/20 at 07:58:39, Yosi_UTC9 wrote:
> nit: Could you add |<< *range| for |DCHECK()|?

Done.

[commit-bot: I haz the power, 2016-09-20 09:45:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 09:45:42]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-09-20 10:01:24]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-09-20 10:01:24]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2351103002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-09-20 10:01:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 10:06:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-20 10:08:25]

Description was changed from

==========
Prune CreateVisiblePositionDeprecated from Editor::canDeleteRange

Editor::canDeleteRange tries to create VisiblePositions when called with
a collapsed range, but the function is only called with a non-collapsed
range. This patch simply removes the dead code for handling collapsed
range and get rid of the creation of VisiblePositions.

BUG=647219
==========

to

==========
Prune CreateVisiblePositionDeprecated from Editor::canDeleteRange

Editor::canDeleteRange tries to create VisiblePositions when called with
a collapsed range, but the function is only called with a non-collapsed
range. This patch simply removes the dead code for handling collapsed
range and get rid of the creation of VisiblePositions.

BUG=647219

Committed: https://crrev.com/0a91d0e81b21800a4c603fb46db2b7648c11ffda
Cr-Commit-Position: refs/heads/master@{#419712}
==========

[commit-bot: I haz the power, 2016-09-20 10:08:25]

Patchset 2 (id:??) landed as
https://crrev.com/0a91d0e81b21800a4c603fb46db2b7648c11ffda
Cr-Commit-Position: refs/heads/master@{#419712}