Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2350323003: Merge can/shouldDeleteRange in Editor (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge can/shouldDeleteRange in Editor Editor::shouldDeleteRange is the only caller of canDeleteRange, and is basically a simple wrapper of the latter. This patch merges the two functions to make code simpler. BUG=n/a TEST=n/a; no behavior change Committed: https://crrev.com/279c13910597a5f745aa59ddd7fdd23b2850edbe Cr-Commit-Position: refs/heads/master@{#419717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 3 chunks +8 lines, -16 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-09-20 09:38:19 UTC) #4
yosin_UTC9
lgtm Thanks for quick work!
4 years, 3 months ago (2016-09-20 09:44:24 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2351103002 Patch 20001). Please resolve the dependency and ...
4 years, 3 months ago (2016-09-20 10:00:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350323003/1
4 years, 3 months ago (2016-09-20 10:23:59 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 10:28:41 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 10:30:25 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/279c13910597a5f745aa59ddd7fdd23b2850edbe
Cr-Commit-Position: refs/heads/master@{#419717}

Powered by Google App Engine
This is Rietveld 408576698