Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2351083003: Update BluetoothChooserControllerTest to test IsConnected() and IsPaired() (Closed)

Created:
4 years, 3 months ago by juncai
Modified:
4 years, 3 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update BluetoothChooserControllerTest to test IsConnected() and IsPaired() Since BluetoothChooserController::IsConnected() and BluetoothChooserController::IsPaired() are added, need to update BluetoothChooserControllerTest to test them. BUG=648801 Committed: https://crrev.com/66c71e73c13562671806cc3017da543a20f7980a Cr-Commit-Position: refs/heads/master@{#420099}

Patch Set 1 : updated BluetoothChooserControllerTest to test IsConnected() and IsPaired() #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc View 1 2 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
juncai
Please take a look. Thanks!
4 years, 3 months ago (2016-09-20 23:50:23 UTC) #4
Jeffrey Yasskin
lgtm https://codereview.chromium.org/2351083003/diff/1/chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc File chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc (right): https://codereview.chromium.org/2351083003/diff/1/chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc#newcode104 chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc:104: EXPECT_TRUE(bluetooth_chooser_controller_.IsConnected(1)); Only the first two EXPECT_TRUE(bluetooth_chooser_controller_.IsXxx(0)); lines look ...
4 years, 3 months ago (2016-09-21 00:39:25 UTC) #7
juncai
https://codereview.chromium.org/2351083003/diff/1/chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc File chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc (right): https://codereview.chromium.org/2351083003/diff/1/chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc#newcode104 chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc:104: EXPECT_TRUE(bluetooth_chooser_controller_.IsConnected(1)); On 2016/09/21 00:39:25, Jeffrey Yasskin wrote: > Only ...
4 years, 3 months ago (2016-09-21 17:43:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351083003/20001
4 years, 3 months ago (2016-09-21 17:44:44 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-21 17:51:25 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 17:55:24 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66c71e73c13562671806cc3017da543a20f7980a
Cr-Commit-Position: refs/heads/master@{#420099}

Powered by Google App Engine
This is Rietveld 408576698