|
|
Chromium Code Reviews|
Created:
4 years, 3 months ago by juncai Modified:
4 years, 3 months ago Reviewers:
Jeffrey Yasskin CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate BluetoothChooserControllerTest to test IsConnected() and IsPaired()
Since BluetoothChooserController::IsConnected() and
BluetoothChooserController::IsPaired() are added, need to update
BluetoothChooserControllerTest to test them.
BUG=648801
Committed: https://crrev.com/66c71e73c13562671806cc3017da543a20f7980a
Cr-Commit-Position: refs/heads/master@{#420099}
Patch Set 1 : updated BluetoothChooserControllerTest to test IsConnected() and IsPaired() #
Total comments: 2
Patch Set 2 : address comments #Messages
Total messages: 18 (12 generated)
The CQ bit was checked by juncai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
juncai@chromium.org changed reviewers: + jyasskin@chromium.org
Please take a look. Thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2351083003/diff/1/chrome/browser/ui/bluetooth... File chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc (right): https://codereview.chromium.org/2351083003/diff/1/chrome/browser/ui/bluetooth... chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc:104: EXPECT_TRUE(bluetooth_chooser_controller_.IsConnected(1)); Only the first two EXPECT_TRUE(bluetooth_chooser_controller_.IsXxx(0)); lines look like they're adding value here. The other 4 have the same data flowing through the same path, so of course they're going to work.
The CQ bit was checked by juncai@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2351083003/diff/1/chrome/browser/ui/bluetooth... File chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc (right): https://codereview.chromium.org/2351083003/diff/1/chrome/browser/ui/bluetooth... chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc:104: EXPECT_TRUE(bluetooth_chooser_controller_.IsConnected(1)); On 2016/09/21 00:39:25, Jeffrey Yasskin wrote: > Only the first two EXPECT_TRUE(bluetooth_chooser_controller_.IsXxx(0)); lines > look like they're adding value here. The other 4 have the same data flowing > through the same path, so of course they're going to work. Done.
The CQ bit was checked by juncai@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jyasskin@chromium.org Link to the patchset: https://codereview.chromium.org/2351083003/#ps20001 (title: "address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Update BluetoothChooserControllerTest to test IsConnected() and IsPaired() Since BluetoothChooserController::IsConnected() and BluetoothChooserController::IsPaired() are added, need to update BluetoothChooserControllerTest to test them. BUG=648801 ========== to ========== Update BluetoothChooserControllerTest to test IsConnected() and IsPaired() Since BluetoothChooserController::IsConnected() and BluetoothChooserController::IsPaired() are added, need to update BluetoothChooserControllerTest to test them. BUG=648801 Committed: https://crrev.com/66c71e73c13562671806cc3017da543a20f7980a Cr-Commit-Position: refs/heads/master@{#420099} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/66c71e73c13562671806cc3017da543a20f7980a Cr-Commit-Position: refs/heads/master@{#420099} |
