Update BluetoothChooserControllerTest to test IsConnected() and IsPaired()

chrome/browser/ui/bluetooth/bluetooth_chooser_controller_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/bluetooth/bluetooth_chooser_controller.h"
@@ skipping 70 matching lines @@
 TEST_F(BluetoothChooserControllerTest, AddDevice) {
   EXPECT_CALL(mock_bluetooth_chooser_view_, OnOptionAdded(0)).Times(1);
   bluetooth_chooser_controller_.AddOrUpdateDevice(
       "id_a", false /* should_update_name */, base::ASCIIToUTF16("a"),
       true /* is_gatt_connected */, true /* is_paired */,
       -1 /* signal_strength_level */);
   EXPECT_EQ(1u, bluetooth_chooser_controller_.NumOptions());
   EXPECT_EQ(base::ASCIIToUTF16("a"),
             bluetooth_chooser_controller_.GetOption(0));
   EXPECT_EQ(-1, bluetooth_chooser_controller_.GetSignalStrengthLevel(0));
+  EXPECT_TRUE(bluetooth_chooser_controller_.IsConnected(0));
+  EXPECT_TRUE(bluetooth_chooser_controller_.IsPaired(0));
   testing::Mock::VerifyAndClearExpectations(&mock_bluetooth_chooser_view_);
 
   EXPECT_CALL(mock_bluetooth_chooser_view_, OnOptionAdded(1)).Times(1);
   bluetooth_chooser_controller_.AddOrUpdateDevice(
       "id_b", false /* should_update_name */, base::ASCIIToUTF16("b"),
       true /* is_gatt_connected */, true /* is_paired */,
       0 /* signal_strength_level */);
   EXPECT_EQ(2u, bluetooth_chooser_controller_.NumOptions());
   EXPECT_EQ(base::ASCIIToUTF16("b"),
             bluetooth_chooser_controller_.GetOption(1));
   EXPECT_EQ(0, bluetooth_chooser_controller_.GetSignalStrengthLevel(1));
+  EXPECT_TRUE(bluetooth_chooser_controller_.IsConnected(1));

[Jeffrey Yasskin, 2016/09/21 00:39:25]

Only the first two EXPECT_TRUE(bluetooth_chooser_controller_.IsXxx(0)); lines
look like they're adding value here. The other 4 have the same data flowing
through the same path, so of course they're going to work.

[juncai, 2016/09/21 17:43:15]

Done.

+  EXPECT_TRUE(bluetooth_chooser_controller_.IsPaired(1));
   testing::Mock::VerifyAndClearExpectations(&mock_bluetooth_chooser_view_);
 
   EXPECT_CALL(mock_bluetooth_chooser_view_, OnOptionAdded(2)).Times(1);
   bluetooth_chooser_controller_.AddOrUpdateDevice(
       "id_c", false /* should_update_name */, base::ASCIIToUTF16("c"),
       true /* is_gatt_connected */, true /* is_paired */,
       1 /* signal_strength_level */);
   EXPECT_EQ(3u, bluetooth_chooser_controller_.NumOptions());
   EXPECT_EQ(base::ASCIIToUTF16("c"),
             bluetooth_chooser_controller_.GetOption(2));
   EXPECT_EQ(1, bluetooth_chooser_controller_.GetSignalStrengthLevel(2));
+  EXPECT_TRUE(bluetooth_chooser_controller_.IsConnected(2));
+  EXPECT_TRUE(bluetooth_chooser_controller_.IsPaired(2));
 }
 
 TEST_F(BluetoothChooserControllerTest, RemoveDevice) {
   bluetooth_chooser_controller_.AddOrUpdateDevice(
       "id_a", false /* should_update_name */, base::ASCIIToUTF16("a"),
       true /* is_gatt_connected */, true /* is_paired */,
       -1 /* signal_strength_level */);
   bluetooth_chooser_controller_.AddOrUpdateDevice(
       "id_b", false /* should_update_name */, base::ASCIIToUTF16("b"),
       true /* is_gatt_connected */, true /* is_paired */,
@@ skipping 113 matching lines @@
   // strength level is -1, and in this case, should still use the previously
   // stored signal strength level. So here the signal strength level is
   // still 1.
   bluetooth_chooser_controller_.AddOrUpdateDevice(
       "id_a", false /* should_update_name */, base::ASCIIToUTF16("a"),
       true /* is_gatt_connected */, true /* is_paired */,
       -1 /* signal_strength_level */);
   EXPECT_EQ(1, bluetooth_chooser_controller_.GetSignalStrengthLevel(0));
 }
 
+TEST_F(BluetoothChooserControllerTest, UpdateConnectedStatus) {
+  bluetooth_chooser_controller_.AddOrUpdateDevice(
+      "id_a", false /* should_update_name */, base::ASCIIToUTF16("a"),
+      false /* is_gatt_connected */, false /* is_paired */,
+      1 /* signal_strength_level */);
+  EXPECT_FALSE(bluetooth_chooser_controller_.IsConnected(0));
+
+  EXPECT_CALL(mock_bluetooth_chooser_view_, OnOptionUpdated(0)).Times(1);
+  bluetooth_chooser_controller_.AddOrUpdateDevice(
+      "id_a", false /* should_update_name */, base::ASCIIToUTF16("a"),
+      true /* is_gatt_connected */, false /* is_paired */,
+      -1 /* signal_strength_level */);
+  EXPECT_TRUE(bluetooth_chooser_controller_.IsConnected(0));
+}
+
+TEST_F(BluetoothChooserControllerTest, UpdatePairedStatus) {
+  bluetooth_chooser_controller_.AddOrUpdateDevice(
+      "id_a", false /* should_update_name */, base::ASCIIToUTF16("a"),
+      true /* is_gatt_connected */, false /* is_paired */,
+      -1 /* signal_strength_level */);
+  EXPECT_FALSE(bluetooth_chooser_controller_.IsPaired(0));
+
+  EXPECT_CALL(mock_bluetooth_chooser_view_, OnOptionUpdated(0)).Times(1);
+  bluetooth_chooser_controller_.AddOrUpdateDevice(
+      "id_a", false /* should_update_name */, base::ASCIIToUTF16("a"),
+      true /* is_gatt_connected */, true /* is_paired */,
+      -1 /* signal_strength_level */);
+  EXPECT_TRUE(bluetooth_chooser_controller_.IsPaired(0));
+}
+
 TEST_F(BluetoothChooserControllerWithDevicesAddedTest,
        InitialNoOptionsTextAndStatusText) {
   EXPECT_EQ(l10n_util::GetStringUTF16(
                 IDS_BLUETOOTH_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT),
             bluetooth_chooser_controller_.GetNoOptionsText());
   EXPECT_EQ(base::string16(), bluetooth_chooser_controller_.GetStatus());
 }
 
 TEST_F(BluetoothChooserControllerWithDevicesAddedTest,
        BluetoothAdapterTurnedOff) {
@@ skipping 76 matching lines @@
   EXPECT_EQ(content::BluetoothChooser::Event::CANCELLED, last_event_);
   EXPECT_EQ(std::string(), last_device_id_);
 }
 
 TEST_F(BluetoothChooserControllerWithDevicesAddedTest,
        CloseShouldCallEventHandler) {
   bluetooth_chooser_controller_.Close();
   EXPECT_EQ(content::BluetoothChooser::Event::CANCELLED, last_event_);
   EXPECT_EQ(std::string(), last_device_id_);
 }