chrome/browser/resources/print_preview/search/destination_search.js - Issue 2351023002: [CUPS] Add a "Manage..." button in the local destinations section of Print Preview Dialog on Chrome…

Unified Diff: chrome/browser/resources/print_preview/search/destination_search.js

Issue 2351023002: [CUPS] Add a "Manage..." button in the local destinations section of Print Preview Dialog on Chrome… (Closed)

Patch Set: Address dbeam@'s comments. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/print_preview/print_preview.js ('K') | « chrome/browser/resources/print_preview/print_preview.js ('k') | chrome/browser/ui/webui/print_preview/print_preview_ui.cc » ('j') | chrome/common/url_constants.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/search/destination_search.js

diff --git a/chrome/browser/resources/print_preview/search/destination_search.js b/chrome/browser/resources/print_preview/search/destination_search.js

index f16cb101d6ddc672776b1ee04569712212193395..5ab5060253c507ef0c553bfe384d9f0e2d81006c 100644

--- a/chrome/browser/resources/print_preview/search/destination_search.js

+++ b/chrome/browser/resources/print_preview/search/destination_search.js

@@ -98,7 +98,8 @@ cr.define('print_preview', function() {

this.localList_ = new print_preview.DestinationList(

this,

loadTimeData.getString('localDestinationsTitle'),

- cr.isChromeOS ? null : loadTimeData.getString('manage'));

+ cr.isChromeOS && loadTimeData.getBoolean('showLocalManageButton') ?

dpapad 2016/09/21 00:39:01 showLocalManageButton will be falsy if not in Chro

xdai1 2016/09/21 18:03:21 showLocalManageButton doesn't exist if not on Chro

dpapad 2016/09/21 18:13:47 See other related. Making it exist for non-ChromeO

xdai1 2016/09/21 18:36:14 Sorry I made a mistake here. We should always show

+ loadTimeData.getString('manage') : null);

this.addChild(this.localList_);

/**