[CUPS] Add a "Manage..." button in the local destinations section of Print Preview Dialog on Chrome…

chrome/browser/resources/print_preview/print_preview.js

Index: chrome/browser/resources/print_preview/print_preview.js
diff --git a/chrome/browser/resources/print_preview/print_preview.js b/chrome/browser/resources/print_preview/print_preview.js
index f220da8eaeb845729eb80a29096f610b74a8c73a..21fecce6aae3b355f7bda7d23cd63f00d7f11d57 100644
--- a/chrome/browser/resources/print_preview/print_preview.js
+++ b/chrome/browser/resources/print_preview/print_preview.js
@@ -963,6 +963,10 @@ cr.define('print_preview', function() {
      * @private
      */
     onManageLocalDestinationsActivated_: function() {
+      if (cr.isChromeOS && loadTimeData.getBoolean('showLocalManageButton')) {

[Dan Beam, 2016/09/21 02:08:40]

getBoolean() fails if the boolean isn't set

it seems like this boolean is only set on ChromeOS

SO, you can do one of two things:

1) loadTimeData.valueExists('showLocalManageButton') &&
loadTimeData.getBoolean('showLocalManageButton')

2) set it to false on !defined(OS_CHROMEOS)

[xdai1, 2016/09/21 18:03:21]

I think that's the reason we need the first clause (cr.isChromeOS):
showLocalManageButton only exists on ChromeOS, so it's guaranteed that
getBoolean() doesn't fail on ChromeOS. 

[dpapad, 2016/09/21 18:13:47]

dbeam's suggestion 2, seems a bit cleaner. showLocalManageButton will exist
always, it will be false on non-ChromeOS, and the ifdef-like conditions will be
limited to the C++, instead of being spread across C++ and JS.

[xdai1, 2016/09/21 18:36:14]

See the comment below. I think I made a mistake in the previous patch.
showLocalManageButton should always be true for systems other than ChromeOS. so
the first clause is necessary here.

+        window.open(loadTimeData.getString('localPrintersManagementURL'));
+        return;
+      }
       this.nativeLayer_.startManageLocalDestinations();
     },