[HBD] Improve Flash Interception unit tests

[HBD] Improve Flash Interception unit tests

This now tests the navigation cancelling aspect separately from the
actual "should intercept" logic.

This improves test coverage to cover paths used by the tab suppression
in ChromeContentBrowserClient.

BUG=641619
Committed: https://crrev.com/46e5537248970ec2555332bd87b4ccdadffdc5b0
Cr-Commit-Position: refs/heads/master@{#420082}

[tommycli, 2016-09-19 19:07:15]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 19:07:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-09-19 19:08:17]

tommycli@chromium.org changed reviewers:
+ raymes@chromium.org

[tommycli, 2016-09-19 19:08:17]

raymes: PTAL, this improves test coverage to cover the window suppression case
also.

It's a followup to your suggestion within
https://codereview.chromium.org/2344293002/

Thanks!

[commit-bot: I haz the power, 2016-09-19 20:17:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 20:17:53]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[raymes, 2016-09-20 01:45:05]

lgtm thanks!

I also feel like we should probably have a browser test for this path eventually
but perhaps that can wait until after the prompt is implemented. It should be
fairly straightforward - run some javascript to trigger the window opening and
check the result. For reference there are some tests here:
https://cs.chromium.org/chromium/src/content/public/test/browser_test_base.h?...

[raymes, 2016-09-20 01:45:33]

On 2016/09/20 01:45:05, raymes wrote:
> lgtm thanks!
> 
> I also feel like we should probably have a browser test for this path
eventually
> but perhaps that can wait until after the prompt is implemented. It should be
> fairly straightforward - run some javascript to trigger the window opening and
> check the result. For reference there are some tests here:
>
https://cs.chromium.org/chromium/src/content/public/test/browser_test_base.h?...

Oops wrong link. I meant here:
https://cs.chromium.org/chromium/src/chrome/browser/pdf/pdf_extension_test.cc...

[tommycli, 2016-09-20 21:32:30]

On 2016/09/20 01:45:33, raymes wrote:
> On 2016/09/20 01:45:05, raymes wrote:
> > lgtm thanks!
> > 
> > I also feel like we should probably have a browser test for this path
> eventually
> > but perhaps that can wait until after the prompt is implemented. It should
be
> > fairly straightforward - run some javascript to trigger the window opening
and
> > check the result. For reference there are some tests here:
> >
>
https://cs.chromium.org/chromium/src/content/public/test/browser_test_base.h?...
> 
> Oops wrong link. I meant here:
>
https://cs.chromium.org/chromium/src/chrome/browser/pdf/pdf_extension_test.cc...

Agreed. I think Browser Tests for this path would be definitely worthwhile to
do. Thanks for the reference!

[tommycli, 2016-09-20 22:36:59]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 22:37:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 23:28:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 23:28:21]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tommycli, 2016-09-21 00:04:40]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 00:05:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 01:00:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 01:00:35]

Dry run: This issue passed the CQ dry run.

[tommycli, 2016-09-21 16:41:05]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-09-21 16:41:06]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/2350913002/#ps20001
(title: "Merge branch 'refs/heads/276-hbd-intercept-creating-new-windows' into
278-hbd-update-intercept-tests")

[commit-bot: I haz the power, 2016-09-21 16:41:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 16:48:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-21 16:50:55]

Description was changed from

==========
[HBD] Improve Flash Interception unit tests

This now tests the navigation cancelling aspect separately from the
actual "should intercept" logic.

This improves test coverage to cover paths used by the tab suppression
in ChromeContentBrowserClient.

BUG=641619
==========

to

==========
[HBD] Improve Flash Interception unit tests

This now tests the navigation cancelling aspect separately from the
actual "should intercept" logic.

This improves test coverage to cover paths used by the tab suppression
in ChromeContentBrowserClient.

BUG=641619

Committed: https://crrev.com/46e5537248970ec2555332bd87b4ccdadffdc5b0
Cr-Commit-Position: refs/heads/master@{#420082}
==========

[commit-bot: I haz the power, 2016-09-21 16:50:56]

Patchset 2 (id:??) landed as
https://crrev.com/46e5537248970ec2555332bd87b4ccdadffdc5b0
Cr-Commit-Position: refs/heads/master@{#420082}