[HBD] Detect user-initiated Flash download in a new window

[HBD] Detect user-initiated Flash download in a new window

Detects (and suprresses) Flash downloads initiated via clicks to links
with target=_blank and JavaScript window.open().

This also suppresses the new window from appearing.

Middle-click and context-menu-open-in-new-window remain unaffected.

BUG=641619
Committed: https://crrev.com/61f6f0c8a8c97375603ea6a14125573e9cbe0e8d
Cr-Commit-Position: refs/heads/master@{#419916}

[tommycli, 2016-09-16 19:15:35]

tommycli@chromium.org changed reviewers:
+ raymes@chromium.org

[tommycli, 2016-09-16 19:15:35]

raymes: PTAL (this CL deals with the intercepts that should trigger the
permission prompt)

Thanks!

[tommycli, 2016-09-16 19:19:29]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 19:20:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 20:14:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 20:14:48]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[raymes, 2016-09-19 02:40:33]

lgtm but I don't know this code very well

Should we add a test to ensure the window opening gets intercepted in the
appropriate cases?

[tommycli, 2016-09-19 16:30:28]

On 2016/09/19 02:40:33, raymes wrote:
> lgtm but I don't know this code very well
> 
> Should we add a test to ensure the window opening gets intercepted in the
> appropriate cases?

Hmm... What if in a followup CL, I changed the
flash_download_interception_unittest tests to test bool
ShouldStopFlashDownloadAction? Then it could cover both the navigation intercept
and CanCreateNewWindow intercepts. Would that work with you?

[tommycli, 2016-09-19 17:51:11]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-09-19 17:51:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 19:35:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 19:35:38]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tommycli, 2016-09-19 20:25:45]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-09-19 20:26:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 21:30:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 21:30:33]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tommycli, 2016-09-20 20:48:40]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 20:49:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-09-20 20:49:58]

raymes: PTAL at the change in host_content_settings_map_factory. It's to fix
that unit test that uses the deprecated TestingProfile::ForceIncognito API.

Without that change, when ForceIncognito is used,
HostContentSettingsMapFactory::BuildServiceInstanceFor goes into an infinite
recursion.

[commit-bot: I haz the power, 2016-09-20 21:57:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 21:57:22]

Dry run: This issue passed the CQ dry run.

[raymes, 2016-09-21 00:19:36]

lgtm

[tommycli, 2016-09-21 00:20:21]

On 2016/09/21 00:19:36, raymes wrote:
> lgtm

thank you! sending it in.

[tommycli, 2016-09-21 00:20:28]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-09-21 00:21:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 00:27:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-21 00:28:30]

Description was changed from

==========
[HBD] Detect user-initiated Flash download in a new window

Detects (and suprresses) Flash downloads initiated via clicks to links
with target=_blank and JavaScript window.open().

This also suppresses the new window from appearing.

Middle-click and context-menu-open-in-new-window remain unaffected.

BUG=641619
==========

to

==========
[HBD] Detect user-initiated Flash download in a new window

Detects (and suprresses) Flash downloads initiated via clicks to links
with target=_blank and JavaScript window.open().

This also suppresses the new window from appearing.

Middle-click and context-menu-open-in-new-window remain unaffected.

BUG=641619

Committed: https://crrev.com/61f6f0c8a8c97375603ea6a14125573e9cbe0e8d
Cr-Commit-Position: refs/heads/master@{#419916}
==========

[commit-bot: I haz the power, 2016-09-21 00:28:31]

Patchset 2 (id:??) landed as
https://crrev.com/61f6f0c8a8c97375603ea6a14125573e9cbe0e8d
Cr-Commit-Position: refs/heads/master@{#419916}