src/IceTargetLoweringMIPS32.cpp - Issue 2350903002: Subzero, MIPS32: lowerUnreachable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringMIPS32.cpp

Issue 2350903002: Subzero, MIPS32: lowerUnreachable (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceTargetLoweringMIPS32.cpp

diff --git a/src/IceTargetLoweringMIPS32.cpp b/src/IceTargetLoweringMIPS32.cpp

index c4b602463f20af75a03df68d14f4f43a92998fa5..147b6a763f9b8022cd5e89a5db16ec2495fb4c5e 100644

--- a/src/IceTargetLoweringMIPS32.cpp

+++ b/src/IceTargetLoweringMIPS32.cpp

@@ -3359,8 +3359,8 @@ void TargetMIPS32::lowerBreakpoint(const InstBreakpoint *Instr) {

UnimplementedLoweringError(this, Instr);

}

-void TargetMIPS32::lowerUnreachable(const InstUnreachable *Instr) {

- UnimplementedLoweringError(this, Instr);

+void TargetMIPS32::lowerUnreachable(const InstUnreachable * /*Instr*/) {

Jim Stichnoth 2016/09/19 23:56:38 I would probably just remove the Instr name: void

obucinac 2016/09/20 13:06:02 Done.

+ _teq(getZero(), getZero(), 0);

Jim Stichnoth 2016/09/19 23:56:38 Can you "document" the 0? constexpr uint32_t Trap

obucinac 2016/09/20 13:06:02 Done.

}

// Turn an i64 Phi instruction into a pair of i32 Phi instructions, to preserve