Subzero, MIPS32: lowerUnreachable

src/IceTargetLoweringMIPS32.cpp

 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
 /// \brief Implements the TargetLoweringMIPS32 class, which consists almost
@@ skipping 3341 matching lines @@
     Value = legalizeToReg(Value);
     _br(NoTargetFalse, TargetTrue, SrcVar, Value, CondMIPS32::Cond::EQ);
   }
   _br(Instr->getLabelDefault());
 }
 
 void TargetMIPS32::lowerBreakpoint(const InstBreakpoint *Instr) {
   UnimplementedLoweringError(this, Instr);
 }
 
-void TargetMIPS32::lowerUnreachable(const InstUnreachable *Instr) {
-  UnimplementedLoweringError(this, Instr);
+void TargetMIPS32::lowerUnreachable(const InstUnreachable * /*Instr*/) {

[Jim Stichnoth, 2016/09/19 23:56:38]

I would probably just remove the Instr name:

void TargetMIPS32::lowerUnreachable(const InstUnreachable *) {

[obucinac, 2016/09/20 13:06:02]

Done.

+  _teq(getZero(), getZero(), 0);

[Jim Stichnoth, 2016/09/19 23:56:38]

Can you "document" the 0?

constexpr uint32_t TrapCodeForWhatever = 0;

[obucinac, 2016/09/20 13:06:02]

Done.

 }
 
 // Turn an i64 Phi instruction into a pair of i32 Phi instructions, to preserve
 // integrity of liveness analysis. Undef values are also turned into zeroes,
 // since loOperand() and hiOperand() don't expect Undef input.
 void TargetMIPS32::prelowerPhis() {
   PhiLowering::prelowerPhis32Bit<TargetMIPS32>(this, Context.getNode(), Func);
 }
 
 void TargetMIPS32::postLower() {
@@ skipping 293 matching lines @@
   Str << "\t.set\t"
       << "nomips16\n";
 }
 
 SmallBitVector TargetMIPS32::TypeToRegisterSet[RCMIPS32_NUM];
 SmallBitVector TargetMIPS32::TypeToRegisterSetUnfiltered[RCMIPS32_NUM];
 SmallBitVector TargetMIPS32::RegisterAliases[RegMIPS32::Reg_NUM];
 
 } // end of namespace MIPS32
 } // end of namespace Ice