Include angle tests in gpu_unittests

Include angle tests in gpu_unittests

If this breaks win builds, please clobber the bots.

BUG=
TEST=gpu_unittests
R=kbr@chromium.org, piman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227161

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235860

[Zhenyao Mo, 2013-09-20 01:42:43]

This is chromium side CL, angle side is

https://codereview.appspot.com/13429045/

[Zhenyao Mo, 2013-09-20 01:43:07]

Please review.

[Ken Russell (switch to Gerrit), 2013-09-20 01:52:14]

LGTM if it's been tested.

[Zhenyao Mo, 2013-09-26 00:09:28]

piman: can you do a review as owner?  I did some change since kbr's last review.

Rather than adding angle unittests as part of gpu_unittests, I made
angle_unittests target.

The plan is to run it on gpu bots first, then add it everywhere.

[piman, 2013-09-26 00:32:52]

lgtm

https://codereview.chromium.org/23509013/diff/6001/gpu/angle_unittest_main.cc
File gpu/angle_unittest_main.cc (right):

https://codereview.chromium.org/23509013/diff/6001/gpu/angle_unittest_main.cc...
gpu/angle_unittest_main.cc:1: // Copyright (c) 2012 The Chromium Authors. All
rights reserved.
nit: new file, fix date.

[Zhenyao Mo, 2013-10-05 01:04:24]

Committed patchset #5 manually as r227161 (presubmit successful).

[Zhenyao Mo, 2013-10-05 01:10:58]

chromium sheriffs: if this breaks win builds, please clobber the bots instead of
reverting this CL.

[justinlin, 2013-10-07 16:52:14]

On 2013/10/05 01:10:58, Zhenyao Mo wrote:
> chromium sheriffs: if this breaks win builds, please clobber the bots instead
of
> reverting this CL.

This is blocking CQ. Seems to still fail to build even with clobber builds (e.g.
https://codereview.chromium.org/25997003/)

"Sorry for I got bad news for ya.
Compile failed with a clobber build on win."

[Ken Russell (switch to Gerrit), 2013-10-07 17:06:56]

Probably a difference between the static and component builds.

[Zhenyao Mo, 2013-10-07 17:12:30]

On 2013/10/07 16:52:14, justinlin wrote:
> On 2013/10/05 01:10:58, Zhenyao Mo wrote:
> > chromium sheriffs: if this breaks win builds, please clobber the bots
instead
> of
> > reverting this CL.
> 
> This is blocking CQ. Seems to still fail to build even with clobber builds
(e.g.
> https://codereview.chromium.org/25997003/)
> 
> "Sorry for I got bad news for ya.
> Compile failed with a clobber build on win."

I don't really understand this.  You can see the win try job compiles fine (with
clobber) under patch set 5.

[Zhenyao Mo, 2013-10-07 18:02:11]

OK, it seems like I get part of the mystery.

It's not clobbering solved the link errors.

I need to define ANGLE_TRANSLATOR_STATIC in angle_unittests to be able to link
to the translator_static correctly.

The clobbered build that lead me to believe (incorrectly) that clobbering would
solve the issue, that build didn't even build angle_unittests, thus compile OK.

That's part of the mystery I still don't get: why sometimes it builds with
angle_unittests, and sometimes I doesn't.

[commit-bot: I haz the power, 2013-11-18 21:00:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zmo@chromium.org/23509013/66001

[commit-bot: I haz the power, 2013-11-19 01:00:51]

Change committed as 235860