Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1218)

Issue 2350883003: Mojo C++ bindings: fix Connector teardown. (Closed)

Created:
4 years, 3 months ago by yzshen1
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: fix Connector teardown. It is allowed to disconnect a Connector instance (by CloseMessagePipe() or PassMessagePipe()) on the creation thread, and then destroy the instance on any thread. However, without this fix it doesn't work because a Connector instance still has got WeakPtr and mojo::Watcher bound to the creation thread. BUG=594244 Committed: https://crrev.com/65085d5fe6a009f01d7630c2905f19e32104ef7c Cr-Commit-Position: refs/heads/master@{#419626}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -21 lines) Patch
M mojo/public/cpp/bindings/connector.h View 4 chunks +6 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/connector.cc View 8 chunks +18 lines, -19 lines 0 comments Download
M mojo/public/cpp/bindings/tests/connector_unittest.cc View 2 chunks +22 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 3 months ago (2016-09-19 22:22:04 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years, 3 months ago (2016-09-19 22:53:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350883003/1
4 years, 3 months ago (2016-09-19 23:21:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 01:25:25 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 01:29:14 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65085d5fe6a009f01d7630c2905f19e32104ef7c
Cr-Commit-Position: refs/heads/master@{#419626}

Powered by Google App Engine
This is Rietveld 408576698