Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2350843003: Remove GYP annotations from third_party GN files. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, eme-reviews_chromium.org, johnmaguire+watch_google.com, haraken, dglazkov+blink, blink-reviews-bindings_chromium.org, jlklein+watch-closure_chromium.org, blink-reviews, vitalyp+closure_chromium.org, kinuko+watch, blink-reviews-api_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GYP annotations from third_party GN files. Since the GYP files have been removed, the "GYP version" annotations above targets can be removed. TBR=dpranke@chromium.org Committed: https://crrev.com/7d75ac6cbf2d866c13b12c9d9a95114ebf5386ff Cr-Commit-Position: refs/heads/master@{#419582}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -62 lines) Patch
M third_party/WebKit/Source/bindings/modules/v8/BUILD.gn View 4 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 11 chunks +0 lines, -16 lines 0 comments Download
M third_party/android_crazy_linker/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/android_opengl/etc1/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/android_platform/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/android_protobuf/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/cacheinvalidation/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/closure_compiler/closure_args.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/decklink/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/errorprone/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/kasko/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/libjingle/BUILD.gn View 4 chunks +0 lines, -4 lines 0 comments Download
M third_party/libphonenumber/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/ub-uiautomator/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350843003/1
4 years, 3 months ago (2016-09-19 21:10:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 21:55:41 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 21:57:55 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7d75ac6cbf2d866c13b12c9d9a95114ebf5386ff
Cr-Commit-Position: refs/heads/master@{#419582}

Powered by Google App Engine
This is Rietveld 408576698