Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: third_party/WebKit/Source/bindings/modules/v8/BUILD.gn

Issue 2350843003: Remove GYP annotations from third_party GN files. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/scripts/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/modules/v8/BUILD.gn
diff --git a/third_party/WebKit/Source/bindings/modules/v8/BUILD.gn b/third_party/WebKit/Source/bindings/modules/v8/BUILD.gn
index 3b658a4710db522659c69d4209910a74776a2754..5c9d6e239eb24a620629b93eb57cc6999759b57f 100644
--- a/third_party/WebKit/Source/bindings/modules/v8/BUILD.gn
+++ b/third_party/WebKit/Source/bindings/modules/v8/BUILD.gn
@@ -9,7 +9,6 @@ import("//third_party/WebKit/Source/modules/modules_idl_files.gni")
visibility = [ "//third_party/WebKit/*" ]
-# bindings_modules_generated in modules/v8/generated.gyp
group("bindings_modules_generated") {
public_deps = [
":bindings_modules_impl_generated",
@@ -20,8 +19,6 @@ group("bindings_modules_generated") {
}
idl_compiler("generate_bindings_modules_v8_interfaces") {
- # Note in GYP this is modules_interface_idl_files but this variable is just
- # defined to modules_definition_idl_files.
sources = modules_definition_idl_files
output_dir = bindings_modules_v8_output_dir
output_name_suffix = ""
@@ -37,8 +34,6 @@ idl_impl("bindings_modules_impl_generated") {
}
idl_compiler("generate_bindings_modules_v8_partial_interfaces") {
- # Note in GYP this is modules_interface_idl_files but this variable is just
- # defined to modules_definition_idl_files.
sources = core_idl_with_modules_dependency_files +
webcore_testing_idl_with_modules_dependency_files
output_dir = bindings_modules_v8_output_dir
@@ -46,7 +41,6 @@ idl_compiler("generate_bindings_modules_v8_partial_interfaces") {
target_component = "modules"
}
-# GYP version: Source/bindings/modules/v8/generated.gyp:bindings_modules_v8_generated_init_partial
action("bindings_modules_v8_generated_init_partial") {
script = "$bindings_scripts_dir/generate_init_partial_interfaces.py"
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/scripts/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698